Re: [Mesa-dev] [PATCH 04/13] glsl: Split default in layout qualifier merge

2016-11-22 Thread Timothy Arceri
On Mon, 2016-11-21 at 18:08 +0200, Andres Gomez wrote: > On Thu, 2016-11-17 at 16:56 +1100, Timothy Arceri wrote: > > > > On Mon, 2016-11-14 at 19:15 +0200, Andres Gomez wrote: > ...  > > > > > > > > diff --git a/src/compiler/glsl/glsl_parser.yy > > > b/src/compiler/glsl/glsl_parser.yy > > > ind

Re: [Mesa-dev] [PATCH 04/13] glsl: Split default in layout qualifier merge

2016-11-21 Thread Andres Gomez
On Thu, 2016-11-17 at 16:56 +1100, Timothy Arceri wrote: > On Mon, 2016-11-14 at 19:15 +0200, Andres Gomez wrote: ...  > > diff --git a/src/compiler/glsl/glsl_parser.yy > > b/src/compiler/glsl/glsl_parser.yy > > index 50f7097..9f18c15 100644 > > --- a/src/compiler/glsl/glsl_parser.yy > > +++ b/src/

Re: [Mesa-dev] [PATCH 04/13] glsl: Split default in layout qualifier merge

2016-11-21 Thread Andres Gomez
On Thu, 2016-11-17 at 16:45 +1100, Timothy Arceri wrote: > I might have asked you this before. Is there a reason why we can't call > merge_qualifier from merge_into_in_qualifier() like we do > in merge_into_out_qualifier() to take care of some of these for us? > Since there is duplicate code. Ans

Re: [Mesa-dev] [PATCH 04/13] glsl: Split default in layout qualifier merge

2016-11-16 Thread Timothy Arceri
On Mon, 2016-11-14 at 19:15 +0200, Andres Gomez wrote: > Currently, the default in layout qualifier merge performs specific > validation and merge. > > We want to split out the validation from the merge so they can be > done > independently. > > Additionally, for simplification, the direction of

Re: [Mesa-dev] [PATCH 04/13] glsl: Split default in layout qualifier merge

2016-11-16 Thread Timothy Arceri
On Mon, 2016-11-14 at 19:15 +0200, Andres Gomez wrote: > Currently, the default in layout qualifier merge performs specific > validation and merge. > > We want to split out the validation from the merge so they can be > done > independently. > > Additionally, for simplification, the direction of

Re: [Mesa-dev] [PATCH 04/13] glsl: Split default in layout qualifier merge

2016-11-16 Thread Timothy Arceri
Patches 3-4 are: Reviewed-by: Timothy Arceri ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 04/13] glsl: Split default in layout qualifier merge

2016-11-14 Thread Andres Gomez
Currently, the default in layout qualifier merge performs specific validation and merge. We want to split out the validation from the merge so they can be done independently. Additionally, for simplification, the direction of the validation and merge is changed so the ast_type_qualifier calling t