Re: [Mesa-dev] [PATCH 04/10] nir: Introduce a nir_opt_move_comparisons() pass.

2017-01-08 Thread Timothy Arceri
On Sat, 2017-01-07 at 07:45 -0800, Jason Ekstrand wrote: > Looks functionally correct.  I left a few simple comments. > > On Jan 7, 2017 3:59 AM, "Timothy Arceri" m> wrote: > From: Kenneth Graunke > > This tries to move comparisons (a common source of boolean values) > closer to their first use

Re: [Mesa-dev] [PATCH 04/10] nir: Introduce a nir_opt_move_comparisons() pass.

2017-01-07 Thread Jason Ekstrand
Looks functionally correct. I left a few simple comments. On Jan 7, 2017 3:59 AM, "Timothy Arceri" wrote: From: Kenneth Graunke This tries to move comparisons (a common source of boolean values) closer to their first use. For GPUs which use condition codes, this can eliminate a lot of tempor

[Mesa-dev] [PATCH 04/10] nir: Introduce a nir_opt_move_comparisons() pass.

2017-01-07 Thread Timothy Arceri
From: Kenneth Graunke This tries to move comparisons (a common source of boolean values) closer to their first use. For GPUs which use condition codes, this can eliminate a lot of temporary booleans and comparisons which reload the condition code register based on a boolean. V2: (Timothy Arceri