Re: [Mesa-dev] [PATCH 04/10] i965/skl: skip fast clears for certain surface formats

2015-11-10 Thread Ben Widawsky
There is one thing I need a response on at the very bottom, the rest will be addressed in v2. Thanks. On Mon, Nov 09, 2015 at 11:33:17AM -0800, Chad Versace wrote: > On Tue 03 Nov 2015, Ben Widawsky wrote: > > On Fri, Oct 16, 2015 at 04:05:22PM -0700, Chad Versace wrote: > > > On Tue 13 Oct 2015,

Re: [Mesa-dev] [PATCH 04/10] i965/skl: skip fast clears for certain surface formats

2015-11-09 Thread Chad Versace
On Tue 03 Nov 2015, Ben Widawsky wrote: > On Fri, Oct 16, 2015 at 04:05:22PM -0700, Chad Versace wrote: > > On Tue 13 Oct 2015, Ben Widawsky wrote: > > > Initially I had this planned as a patch to be squashed in to the enabling > > > patch > > > because there is no point enabling fast clears witho

Re: [Mesa-dev] [PATCH 04/10] i965/skl: skip fast clears for certain surface formats

2015-11-03 Thread Ben Widawsky
On Fri, Oct 16, 2015 at 04:05:22PM -0700, Chad Versace wrote: > On Tue 13 Oct 2015, Ben Widawsky wrote: > > Initially I had this planned as a patch to be squashed in to the enabling > > patch > > because there is no point enabling fast clears without this. However, Chad > > merged a patch which di

Re: [Mesa-dev] [PATCH 04/10] i965/skl: skip fast clears for certain surface formats

2015-10-16 Thread Chad Versace
On Tue 13 Oct 2015, Ben Widawsky wrote: > Initially I had this planned as a patch to be squashed in to the enabling > patch > because there is no point enabling fast clears without this. However, Chad > merged a patch which disables fast clears on gen9 explicitly, and so I can > hide > this behin

Re: [Mesa-dev] [PATCH 04/10] i965/skl: skip fast clears for certain surface formats

2015-10-14 Thread Ben Widawsky
On Wed, Oct 14, 2015 at 01:10:23PM +0200, Neil Roberts wrote: > It would be nice if you could give some indication of where this list of > formats came from. > > Unless we expect the list to change with future generations, maybe it > would be better to make it a static const table? It's a shame to

Re: [Mesa-dev] [PATCH 04/10] i965/skl: skip fast clears for certain surface formats

2015-10-14 Thread Neil Roberts
It would be nice if you could give some indication of where this list of formats came from. Unless we expect the list to change with future generations, maybe it would be better to make it a static const table? It's a shame to grow the context size unnecessarily. Regards, - Neil Ben Widawsky wr

Re: [Mesa-dev] [PATCH 04/10] i965/skl: skip fast clears for certain surface formats

2015-10-13 Thread Matt Turner
On Tue, Oct 13, 2015 at 8:50 PM, Ben Widawsky wrote: > Initially I had this planned as a patch to be squashed in to the enabling > patch > because there is no point enabling fast clears without this. However, Chad > merged a patch which disables fast clears on gen9 explicitly, and so I can > hid

[Mesa-dev] [PATCH 04/10] i965/skl: skip fast clears for certain surface formats

2015-10-13 Thread Ben Widawsky
Initially I had this planned as a patch to be squashed in to the enabling patch because there is no point enabling fast clears without this. However, Chad merged a patch which disables fast clears on gen9 explicitly, and so I can hide this behind the revert of that patch. This is a nice I really wa