Re: [Mesa-dev] [PATCH 03/15] i965: Make swizzle_to_scs non-static.

2013-11-13 Thread Chris Forbes
Reviewed-by: Chris Forbes Without any docs, I don't feel qualified enough to review beyond this patch, but it looks generally sensible. On Wed, Nov 13, 2013 at 2:50 PM, Kenneth Graunke wrote: > We'll need this for Broadwell code as well. > > Normally, when we make things public, we add the "brw

[Mesa-dev] [PATCH 03/15] i965: Make swizzle_to_scs non-static.

2013-11-12 Thread Kenneth Graunke
We'll need this for Broadwell code as well. Normally, when we make things public, we add the "brw" prefix. I'm not crazy about that in this case, since it deals with prog_instruction.h's SWIZZLE_XYZW values, rather than the BRW_SWIZZLE_XYZW enums. However, I can't think of a better name, and at