Re: [Mesa-dev] [PATCH 03/11] radeon: remove dri_mirror state

2015-07-09 Thread Ian Romanick
On 07/08/2015 10:07 AM, Emil Velikov wrote: > Most of the data stored(duplicated) was unused, and for the one that is > follow the approach set by other drivers. > This eliminates the use of legacy (dri1) types. > > XXX: The radeon code is the only user of __DRIscreen::drm_version (the > only __DR

Re: [Mesa-dev] [PATCH 03/11] radeon: remove dri_mirror state

2015-07-09 Thread Emil Velikov
On 9 July 2015 at 14:16, Marek Olšák wrote: > "major != 2" can't occur. You don't have to check the major version at > all and you can just assume it's always 2. > That's even better than expected. Thanks ! -Emil ___ mesa-dev mailing list mesa-dev@lists

Re: [Mesa-dev] [PATCH 03/11] radeon: remove dri_mirror state

2015-07-09 Thread Marek Olšák
"major != 2" can't occur. You don't have to check the major version at all and you can just assume it's always 2. Marek On Thu, Jul 9, 2015 at 2:55 PM, Emil Velikov wrote: > On 9 July 2015 at 04:45, Michel Dänzer wrote: >> On 09.07.2015 02:07, Emil Velikov wrote: >>> Most of the data stored(dup

Re: [Mesa-dev] [PATCH 03/11] radeon: remove dri_mirror state

2015-07-09 Thread Emil Velikov
On 9 July 2015 at 04:45, Michel Dänzer wrote: > On 09.07.2015 02:07, Emil Velikov wrote: >> Most of the data stored(duplicated) was unused, and for the one that is >> follow the approach set by other drivers. >> This eliminates the use of legacy (dri1) types. > > The commentary below should have b

Re: [Mesa-dev] [PATCH 03/11] radeon: remove dri_mirror state

2015-07-08 Thread Michel Dänzer
On 09.07.2015 02:07, Emil Velikov wrote: > Most of the data stored(duplicated) was unused, and for the one that is > follow the approach set by other drivers. > This eliminates the use of legacy (dri1) types. The commentary below should have been after the --- separator, not in the actual Git comm

[Mesa-dev] [PATCH 03/11] radeon: remove dri_mirror state

2015-07-08 Thread Emil Velikov
Most of the data stored(duplicated) was unused, and for the one that is follow the approach set by other drivers. This eliminates the use of legacy (dri1) types. XXX: The radeon code is the only user of __DRIscreen::drm_version (the only __DRIversion outside of dri1 land). Should we move it into r