On Wed, 2016-07-20 at 12:15 -0700, Kenneth Graunke wrote:
> On Tuesday, July 19, 2016 4:33:14 PM PDT Timothy Arceri wrote:
> > Rather than trying to work out the total number of components
> > used at a location we simply treat all outputs as vec4s.
> > ---
> > src/mesa/drivers/dri/i965/brw_fs.h
On Tuesday, July 19, 2016 4:33:14 PM PDT Timothy Arceri wrote:
> Rather than trying to work out the total number of components
> used at a location we simply treat all outputs as vec4s.
> ---
> src/mesa/drivers/dri/i965/brw_fs.h | 1 -
> src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 22
On 19/07/16 08:33, Timothy Arceri wrote:
> Rather than trying to work out the total number of components
> used at a location we simply treat all outputs as vec4s.
Probably it would be good to explain a little the why on the commit
message, and not just the what. In either case:
Reviewed-by: Aleja
On Tue, 2016-07-19 at 13:03 +0200, Alejandro Piñeiro wrote:
> Is this the correct version of the patch? It uses nir_lower_io with 4
> parameters, while nir_lower_io on master uses 3 (and afaik, it has
> been
> using 3 for a while).
>
> FWIW, this patch doesn't apply cleanly with current master mes
Is this the correct version of the patch? It uses nir_lower_io with 4
parameters, while nir_lower_io on master uses 3 (and afaik, it has been
using 3 for a while).
FWIW, this patch doesn't apply cleanly with current master mesa.
BR
On 19/07/16 08:33, Timothy Arceri wrote:
> Rather than trying to
Rather than trying to work out the total number of components
used at a location we simply treat all outputs as vec4s.
---
src/mesa/drivers/dri/i965/brw_fs.h | 1 -
src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 22 ++
src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 1
