Re: [Mesa-dev] [PATCH 02/11] spirv: Add tessellation varying and built-in support.

2017-01-09 Thread Jason Ekstrand
I hate decorations... 1 and 2 are Reviewed-by: Jason Ekstrand On Mon, Jan 9, 2017 at 7:16 AM, Iago Toral wrote: > On Sun, 2017-01-08 at 21:26 -0800, Kenneth Graunke wrote: > > We need to: > > - handle the extra array level for per-vertex varyings > > - handle the patch qualifier correctly > >

Re: [Mesa-dev] [PATCH 02/11] spirv: Add tessellation varying and built-in support.

2017-01-09 Thread Iago Toral
On Sun, 2017-01-08 at 21:26 -0800, Kenneth Graunke wrote: > We need to: > - handle the extra array level for per-vertex varyings > - handle the patch qualifier correctly > - assign varying locations > > Signed-off-by: Kenneth Graunke > --- >  src/compiler/spirv/vtn_private.h   |  1 + >  src/compi

Re: [Mesa-dev] [PATCH 02/11] spirv: Add tessellation varying and built-in support.

2017-01-08 Thread Dave Airlie
On 9 January 2017 at 15:26, Kenneth Graunke wrote: > We need to: > - handle the extra array level for per-vertex varyings > - handle the patch qualifier correctly > - assign varying locations > > Signed-off-by: Kenneth Graunke Seems sane, Reviewed-by: Dave Airlie > --- > src/compiler/spirv/vt

[Mesa-dev] [PATCH 02/11] spirv: Add tessellation varying and built-in support.

2017-01-08 Thread Kenneth Graunke
We need to: - handle the extra array level for per-vertex varyings - handle the patch qualifier correctly - assign varying locations Signed-off-by: Kenneth Graunke --- src/compiler/spirv/vtn_private.h | 1 + src/compiler/spirv/vtn_variables.c | 56 ++ 2 fil