Re: [Mesa-dev] [PATCH 02/10] nir: Add a loop analysis pass

2016-09-19 Thread Timothy Arceri
On Fri, 2016-09-16 at 15:25 -0700, Jason Ekstrand wrote: > > On Thu, Sep 15, 2016 at 12:03 AM, Timothy Arceri wrote: > > > > From: Thomas Helland > > > > > > This pass detects induction variables and calculates the > > > > trip count of loops to be used for loop unrolling. > > > > > > > > I

Re: [Mesa-dev] [PATCH 02/10] nir: Add a loop analysis pass

2016-09-19 Thread Timothy Arceri
I sent this reply on Saturday however is seems something went wrong and it didn't make it out so here it is again. On Fri, 2016-09-16 at 15:25 -0700, Jason Ekstrand wrote: > On Thu, Sep 15, 2016 at 12:03 AM, Timothy Arceri abora.com> wrote: > > From: Thomas Helland > > > > This pass detects ind

Re: [Mesa-dev] [PATCH 02/10] nir: Add a loop analysis pass

2016-09-16 Thread Jason Ekstrand
On Fri, Sep 16, 2016 at 5:36 PM, Connor Abbott wrote: > On Fri, Sep 16, 2016 at 6:25 PM, Jason Ekstrand > wrote: > > On Thu, Sep 15, 2016 at 12:03 AM, Timothy Arceri > > wrote: > >> > >> From: Thomas Helland > >> > >> This pass detects induction variables and calculates the > >> trip count of

Re: [Mesa-dev] [PATCH 02/10] nir: Add a loop analysis pass

2016-09-16 Thread Connor Abbott
On Fri, Sep 16, 2016 at 6:25 PM, Jason Ekstrand wrote: > On Thu, Sep 15, 2016 at 12:03 AM, Timothy Arceri > wrote: >> >> From: Thomas Helland >> >> This pass detects induction variables and calculates the >> trip count of loops to be used for loop unrolling. >> >> I've removed support for float

Re: [Mesa-dev] [PATCH 02/10] nir: Add a loop analysis pass

2016-09-16 Thread Timothy Arceri
On Sat, 2016-09-17 at 09:40 +1000, Timothy Arceri wrote: > On Fri, 2016-09-16 at 15:25 -0700, Jason Ekstrand wrote: > > > > On Thu, Sep 15, 2016 at 12:03 AM, Timothy Arceri wrote: > > > > > > From: Thomas Helland > > > > snip > > >   > > > > > > > > > > > > > > > > > > > > > > > > > > > > >

Re: [Mesa-dev] [PATCH 02/10] nir: Add a loop analysis pass

2016-09-16 Thread Timothy Arceri
On Fri, 2016-09-16 at 17:01 +0200, Erik Faye-Lund wrote: > On Thu, Sep 15, 2016 at 9:03 AM, Timothy Arceri > wrote: > > > > +   const int bias[] = { -1, 1, 1 }; > > + > > +   for (unsigned i = 0; i < ARRAY_SIZE(bias); i++) { > > +  iter_int = iter_int + bias[i]; > > + > > +  switch (cond_

Re: [Mesa-dev] [PATCH 02/10] nir: Add a loop analysis pass

2016-09-16 Thread Jason Ekstrand
On Thu, Sep 15, 2016 at 12:03 AM, Timothy Arceri < timothy.arc...@collabora.com> wrote: > From: Thomas Helland > > This pass detects induction variables and calculates the > trip count of loops to be used for loop unrolling. > > I've removed support for float induction values for now, for the > s

Re: [Mesa-dev] [PATCH 02/10] nir: Add a loop analysis pass

2016-09-16 Thread Erik Faye-Lund
On Thu, Sep 15, 2016 at 9:03 AM, Timothy Arceri wrote: > + const int bias[] = { -1, 1, 1 }; > + > + for (unsigned i = 0; i < ARRAY_SIZE(bias); i++) { > + iter_int = iter_int + bias[i]; > + > + switch (cond_op) { > + case nir_op_ige: > + case nir_op_ilt: > + case nir_op

[Mesa-dev] [PATCH 02/10] nir: Add a loop analysis pass

2016-09-15 Thread Timothy Arceri
From: Thomas Helland This pass detects induction variables and calculates the trip count of loops to be used for loop unrolling. I've removed support for float induction values for now, for the simple reason that they don't appear in my shader-db collection, and so I don't see it as common enoug