Re: [Mesa-dev] [PATCH 01/41] glapi: Added ARB_direct_state_access.xml file.

2015-01-23 Thread Laura Ekstrand
Emil, In situations such as your TEXTURE_TARGET example, the functionality is not exposed to non-DSA functions. I've been making the backend functions take a bool dsa that instructs them how to behave depending on whether or not glTexParameter or glTextureParameter is called. Now this is arguabl

Re: [Mesa-dev] [PATCH 01/41] glapi: Added ARB_direct_state_access.xml file.

2015-01-23 Thread Emil Velikov
On 23/01/15 21:53, Jason Ekstrand wrote: > > > On Fri, Jan 23, 2015 at 1:46 PM, Emil Velikov > wrote: > > On 23/01/15 20:51, Jason Ekstrand wrote: > > > > > > On Thu, Jan 22, 2015 at 9:27 AM, Emil Velikov >

Re: [Mesa-dev] [PATCH 01/41] glapi: Added ARB_direct_state_access.xml file.

2015-01-23 Thread Ian Romanick
On 01/23/2015 01:53 PM, Jason Ekstrand wrote: > On Fri, Jan 23, 2015 at 1:46 PM, Emil Velikov > wrote: > On 23/01/15 20:51, Jason Ekstrand wrote: > > On Thu, Jan 22, 2015 at 9:27 AM, Emil Velikov > >

Re: [Mesa-dev] [PATCH 01/41] glapi: Added ARB_direct_state_access.xml file.

2015-01-23 Thread Jason Ekstrand
On Fri, Jan 23, 2015 at 1:46 PM, Emil Velikov wrote: > On 23/01/15 20:51, Jason Ekstrand wrote: > > > > > > On Thu, Jan 22, 2015 at 9:27 AM, Emil Velikov > > wrote: > > > > On 05/01/15 17:45, Laura Ekstrand wrote: > > > This comment is vague. Do you have

Re: [Mesa-dev] [PATCH 01/41] glapi: Added ARB_direct_state_access.xml file.

2015-01-23 Thread Emil Velikov
On 23/01/15 20:51, Jason Ekstrand wrote: > > > On Thu, Jan 22, 2015 at 9:27 AM, Emil Velikov > wrote: > > On 05/01/15 17:45, Laura Ekstrand wrote: > > This comment is vague. Do you have a specific recommendation for the > > code here? > > >

Re: [Mesa-dev] [PATCH 01/41] glapi: Added ARB_direct_state_access.xml file.

2015-01-23 Thread Jason Ekstrand
On Thu, Jan 22, 2015 at 9:27 AM, Emil Velikov wrote: > On 05/01/15 17:45, Laura Ekstrand wrote: > > This comment is vague. Do you have a specific recommendation for the > > code here? > > > Seems like I'm way too subtle - yes I have a few. > > > 1. Add ARB_direct_state_access to struct gl_extens

Re: [Mesa-dev] [PATCH 01/41] glapi: Added ARB_direct_state_access.xml file.

2015-01-22 Thread Emil Velikov
On 05/01/15 17:45, Laura Ekstrand wrote: > This comment is vague. Do you have a specific recommendation for the > code here? > Seems like I'm way too subtle - yes I have a few. 1. Add ARB_direct_state_access to struct gl_extension --- a/src/mesa/main/mtypes.h +++ b/src/mesa/main/mtypes.h @@ -37

Re: [Mesa-dev] [PATCH 01/41] glapi: Added ARB_direct_state_access.xml file.

2015-01-05 Thread Laura Ekstrand
This comment is vague. Do you have a specific recommendation for the code here? Thanks. Laura On Sat, Jan 3, 2015 at 7:17 AM, Emil Velikov wrote: > On 30/12/14 22:20, Laura Ekstrand wrote: > > To run this partial implementation, > > > > export MESA_EXTENSION_OVERRIDE=+GL_ARB_direct_state_acce

Re: [Mesa-dev] [PATCH 01/41] glapi: Added ARB_direct_state_access.xml file.

2015-01-03 Thread Emil Velikov
On 30/12/14 22:20, Laura Ekstrand wrote: > To run this partial implementation, > > export MESA_EXTENSION_OVERRIDE=+GL_ARB_direct_state_access > Indeed that does the job. Yet it seems that I was slightly confused with the usage/application of the boolean variable(s) - i.e. they seem to be used whe

Re: [Mesa-dev] [PATCH 01/41] glapi: Added ARB_direct_state_access.xml file.

2014-12-30 Thread Laura Ekstrand
To run this partial implementation, export MESA_EXTENSION_OVERRIDE=+GL_ARB_direct_state_access I just did that and my dsa piglit tests ran fine. Laura On Mon, Dec 29, 2014 at 3:25 PM, Emil Velikov wrote: > On 16/12/14 01:22, Laura Ekstrand wrote: > > diff --git a/src/mesa/main/extensions.c b/

Re: [Mesa-dev] [PATCH 01/41] glapi: Added ARB_direct_state_access.xml file.

2014-12-29 Thread Emil Velikov
On 16/12/14 01:22, Laura Ekstrand wrote: > diff --git a/src/mesa/main/extensions.c b/src/mesa/main/extensions.c > index f0e2f89..6aba159 100644 > --- a/src/mesa/main/extensions.c > +++ b/src/mesa/main/extensions.c > @@ -103,6 +103,7 @@ static const struct extension extension_table[] = { > { "GL

[Mesa-dev] [PATCH 01/41] glapi: Added ARB_direct_state_access.xml file.

2014-12-15 Thread Laura Ekstrand
main: Added ARB_direct_state_access to extensions.c as dummy_false. --- src/mapi/glapi/gen/ARB_direct_state_access.xml | 11 +++ src/mapi/glapi/gen/Makefile.am | 1 + src/mapi/glapi/gen/gl_API.xml | 6 +- src/mesa/main/extensions.c