Re: [Mesa-dev] [PATCH 01/14] util: fix ElfW macro

2018-01-18 Thread Greg V
On 01/18/2018 19:57, Emil Velikov wrote: On 31 December 2017 at 16:55, Greg V wrote: Elf64_Nhdr exists, Elf_Nhdr does not. Can you please add a typedef in FreeBSD sources, pretty please? I'm not a committer :) raised an issue in bugzilla: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=2253

Re: [Mesa-dev] [PATCH 01/14] util: fix ElfW macro

2018-01-18 Thread Emil Velikov
On 18 January 2018 at 17:59, Greg V wrote: > On 01/18/2018 19:57, Emil Velikov wrote: >> >> On 31 December 2017 at 16:55, Greg V wrote: >>> >>> Elf64_Nhdr exists, Elf_Nhdr does not. >> >> Can you please add a typedef in FreeBSD sources, pretty please? > > I'm not a committer :) raised an issue in

Re: [Mesa-dev] [PATCH 01/14] util: fix ElfW macro

2018-01-18 Thread Emil Velikov
On 31 December 2017 at 16:55, Greg V wrote: > Elf64_Nhdr exists, Elf_Nhdr does not. > This doesn't sound right. Having a look at FreeBSD [1] it seems that it aliases Elf{32,64}_Nhdr to Elf_Note and not Elf_Nhdr?! In practise the layout of Nhdr and Note is identical, although the former has a n_ pr

[Mesa-dev] [PATCH 01/14] util: fix ElfW macro

2018-01-03 Thread Greg V
Elf64_Nhdr exists, Elf_Nhdr does not. Obtained from: FreeBSD ports --- src/util/build_id.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/util/build_id.c b/src/util/build_id.c index 536c74360e..cb35e90b09 100644 --- a/src/util/build_id.c +++ b/src/util/build_id.c @@