Re: [Mesa-dev] [PATCH 01/13] nir: allow 64 bit shifts

2018-02-28 Thread Jason Ekstrand
On Wed, Feb 28, 2018 at 1:35 PM, Rob Clark wrote: > On Wed, Feb 28, 2018 at 4:18 PM, Karol Herbst wrote: > > On Wed, Feb 28, 2018 at 9:46 PM, Jason Ekstrand > wrote: > >> I do not think this patch does what you think it does. The old opcode > >> allowed you to shift any bit size integer by a 3

Re: [Mesa-dev] [PATCH 01/13] nir: allow 64 bit shifts

2018-02-28 Thread Jason Ekstrand
On Wed, Feb 28, 2018 at 1:18 PM, Karol Herbst wrote: > On Wed, Feb 28, 2018 at 9:46 PM, Jason Ekstrand > wrote: > > I do not think this patch does what you think it does. The old opcode > > allowed you to shift any bit size integer by a 32-bit integer. The new > > version allows you to shift N

Re: [Mesa-dev] [PATCH 01/13] nir: allow 64 bit shifts

2018-02-28 Thread Rob Clark
On Wed, Feb 28, 2018 at 4:18 PM, Karol Herbst wrote: > On Wed, Feb 28, 2018 at 9:46 PM, Jason Ekstrand wrote: >> I do not think this patch does what you think it does. The old opcode >> allowed you to shift any bit size integer by a 32-bit integer. The new >> version allows you to shift N bits

Re: [Mesa-dev] [PATCH 01/13] nir: allow 64 bit shifts

2018-02-28 Thread Karol Herbst
On Wed, Feb 28, 2018 at 9:46 PM, Jason Ekstrand wrote: > I do not think this patch does what you think it does. The old opcode > allowed you to shift any bit size integer by a 32-bit integer. The new > version allows you to shift N bits by N bits. In particular, you can't > shift a 16-bit by a

Re: [Mesa-dev] [PATCH 01/13] nir: allow 64 bit shifts

2018-02-28 Thread Jason Ekstrand
I do not think this patch does what you think it does. The old opcode allowed you to shift any bit size integer by a 32-bit integer. The new version allows you to shift N bits by N bits. In particular, you can't shift a 16-bit by a 32-bit value. I'm not sure what the best thing is to do here.

[Mesa-dev] [PATCH 01/13] nir: allow 64 bit shifts

2018-02-28 Thread Rob Clark
From: Karol Herbst This is a thing for OpenCL kernels. Signed-off-by: Rob Clark --- src/compiler/nir/nir_opcodes.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/compiler/nir/nir_opcodes.py b/src/compiler/nir/nir_opcodes.py index 278562b2bd1..c4d2c7805eb 100644