Re: [Mesa-dev] [PATCH 01/13] egl/dri: Avoid out of bounds array access

2019-01-31 Thread Emil Velikov
On Wed, 30 Jan 2019 at 23:07, Strasser, Kevin wrote: > > Emile Velikov wrote: > > JFYI: > > Checking the offending commit (like below) allows us to better track > > where the patch is need plus it gives you a few automatic reviewers > > ;-) > > > > Cc: Chad Versace > > Cc: Eric Engestrom > > Fix

Re: [Mesa-dev] [PATCH 01/13] egl/dri: Avoid out of bounds array access

2019-01-30 Thread Strasser, Kevin
Emile Velikov wrote: > JFYI: > Checking the offending commit (like below) allows us to better track > where the patch is need plus it gives you a few automatic reviewers > ;-) > > Cc: Chad Versace > Cc: Eric Engestrom > Fixes: cd717cbe1a6 ("egl/dri2: Declare loop vars inside the loop") > > Review

Re: [Mesa-dev] [PATCH 01/13] egl/dri: Avoid out of bounds array access

2019-01-30 Thread Emil Velikov
On Mon, 28 Jan 2019 at 18:42, Kevin Strasser wrote: > > indexConfigAttrib iterates over every index in the dri driver, possibly > exceeding __DRI_ATTRIB_MAX. In other words, if the dri driver has newer > attributes libEGL will end up reading from uninitialized memory through > dri2_to_egl_attribut

[Mesa-dev] [PATCH 01/13] egl/dri: Avoid out of bounds array access

2019-01-28 Thread Kevin Strasser
indexConfigAttrib iterates over every index in the dri driver, possibly exceeding __DRI_ATTRIB_MAX. In other words, if the dri driver has newer attributes libEGL will end up reading from uninitialized memory through dri2_to_egl_attribute_map[]. Signed-off-by: Kevin Strasser Cc: mesa-sta...@lists.