Re: [Mesa-dev] [PATCH 01/12] vl: add parameters for VAAPI encode

2016-07-16 Thread Andy Furniss
Andy Furniss wrote: Zhang, Boyuan wrote: Hi Andy, The memory issue is fixed. Please try the new patch set I just submitted. Should NOT have hard lock anymore. And thanks for providing the rate control info, I will do some test about it. Another issue is decode -> encode, this works OK with o

Re: [Mesa-dev] [PATCH 01/12] vl: add parameters for VAAPI encode

2016-07-16 Thread Andy Furniss
Zhang, Boyuan wrote: Hi Andy, The memory issue is fixed. Please try the new patch set I just submitted. Should NOT have hard lock anymore. And thanks for providing the rate control info, I will do some test about it. Another issue is decode -> encode, this works OK with omx, but with someth

Re: [Mesa-dev] [PATCH 01/12] vl: add parameters for VAAPI encode

2016-07-15 Thread Andy Furniss
Zhang, Boyuan wrote: Hi Andy, The memory issue is fixed. Please try the new patch set I just submitted. Should NOT have hard lock anymore. Seems good, no leak and no lock :-) ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.fr

Re: [Mesa-dev] [PATCH 01/12] vl: add parameters for VAAPI encode

2016-07-15 Thread Zhang, Boyuan
: July-15-16 1:32 PM To: Zhang, Boyuan; Christian König; mesa-dev@lists.freedesktop.org Subject: Re: [Mesa-dev] [PATCH 01/12] vl: add parameters for VAAPI encode Zhang, Boyuan wrote: > Hi Andy, > > Thanks for the testing. I will look into the memory issue. For the cbr > test, what was

Re: [Mesa-dev] [PATCH 01/12] vl: add parameters for VAAPI encode

2016-07-15 Thread Andy Furniss
Andy Furniss wrote: omx doesn't have this issue, for 30mbit the files produced are 53M and 26M. Actually by default omx will make the same size files, I lucked into that behavior playing around with the control-rate param. ___ mesa-dev mailing list

Re: [Mesa-dev] [PATCH 01/12] vl: add parameters for VAAPI encode

2016-07-15 Thread Andy Furniss
Zhang, Boyuan wrote: Hi Andy, Thanks for the testing. I will look into the memory issue. For the cbr test, what was the bitrate you set? And by saying testing high rates, how high was the rate approximately? Testing more shows that I get the same size file independent of framerate. An example

Re: [Mesa-dev] [PATCH 01/12] vl: add parameters for VAAPI encode

2016-07-15 Thread Zhang, Boyuan
-16 9:42 AM To: Christian König; Zhang, Boyuan; mesa-dev@lists.freedesktop.org Subject: Re: [Mesa-dev] [PATCH 01/12] vl: add parameters for VAAPI encode Christian König wrote: > Am 05.07.2016 um 13:17 schrieb Christian König: >> Am 01.07.2016 um 18:18 schrieb Andy Furniss: >>> Chr

Re: [Mesa-dev] [PATCH 01/12] vl: add parameters for VAAPI encode

2016-07-15 Thread Andy Furniss
Christian König wrote: Am 05.07.2016 um 13:17 schrieb Christian König: Am 01.07.2016 um 18:18 schrieb Andy Furniss: Christian König wrote: Am 01.07.2016 um 18:02 schrieb Andy Furniss: Christian König wrote: Am 01.07.2016 um 16:42 schrieb Andy Furniss: Boyuan Zhang wrote: Signed-off-by: Boy

Re: [Mesa-dev] [PATCH 01/12] vl: add parameters for VAAPI encode

2016-07-14 Thread Christian König
Am 05.07.2016 um 13:17 schrieb Christian König: Am 01.07.2016 um 18:18 schrieb Andy Furniss: Christian König wrote: Am 01.07.2016 um 18:02 schrieb Andy Furniss: Christian König wrote: Am 01.07.2016 um 16:42 schrieb Andy Furniss: Boyuan Zhang wrote: Signed-off-by: Boyuan Zhang Is this sup

Re: [Mesa-dev] [PATCH 01/12] vl: add parameters for VAAPI encode

2016-07-13 Thread Zhang, Boyuan
Hi Emil, Thanks for the suggestion. I added brief message to each of the patch to explain what the patch does. Please see the new patch set I just submitted. Hi Christian, The un-used ref_pic related definitions are removed from this patch. For the concern of is_idr flag , I checked the b

Re: [Mesa-dev] [PATCH 01/12] vl: add parameters for VAAPI encode

2016-07-05 Thread Christian König
Am 01.07.2016 um 18:18 schrieb Andy Furniss: Christian König wrote: Am 01.07.2016 um 18:02 schrieb Andy Furniss: Christian König wrote: Am 01.07.2016 um 16:42 schrieb Andy Furniss: Boyuan Zhang wrote: Signed-off-by: Boyuan Zhang Is this supposed to be the same functionally as the first ve

Re: [Mesa-dev] [PATCH 01/12] vl: add parameters for VAAPI encode

2016-07-01 Thread Andy Furniss
Christian König wrote: Am 01.07.2016 um 18:02 schrieb Andy Furniss: Christian König wrote: Am 01.07.2016 um 16:42 schrieb Andy Furniss: Boyuan Zhang wrote: Signed-off-by: Boyuan Zhang Is this supposed to be the same functionally as the first version? I notice on Tonga that I previously go

Re: [Mesa-dev] [PATCH 01/12] vl: add parameters for VAAPI encode

2016-07-01 Thread Christian König
Am 01.07.2016 um 18:02 schrieb Andy Furniss: Christian König wrote: Am 01.07.2016 um 16:42 schrieb Andy Furniss: Boyuan Zhang wrote: Signed-off-by: Boyuan Zhang Is this supposed to be the same functionally as the first version? I notice on Tonga that I previously got cabac, but don't now.

Re: [Mesa-dev] [PATCH 01/12] vl: add parameters for VAAPI encode

2016-07-01 Thread Andy Furniss
Christian König wrote: Am 01.07.2016 um 16:42 schrieb Andy Furniss: Boyuan Zhang wrote: Signed-off-by: Boyuan Zhang Is this supposed to be the same functionally as the first version? I notice on Tonga that I previously got cabac, but don't now. I see the new options are now in radeon_vce_5

Re: [Mesa-dev] [PATCH 01/12] vl: add parameters for VAAPI encode

2016-07-01 Thread Christian König
Am 01.07.2016 um 16:42 schrieb Andy Furniss: Boyuan Zhang wrote: Signed-off-by: Boyuan Zhang Is this supposed to be the same functionally as the first version? I notice on Tonga that I previously got cabac, but don't now. I see the new options are now in radeon_vce_52.c whereas before radeo

Re: [Mesa-dev] [PATCH 01/12] vl: add parameters for VAAPI encode

2016-07-01 Thread Andy Furniss
Boyuan Zhang wrote: Signed-off-by: Boyuan Zhang Is this supposed to be the same functionally as the first version? I notice on Tonga that I previously got cabac, but don't now. I see the new options are now in radeon_vce_52.c whereas before radeon_vce_40_2_2.c was changed - is this why? TIA

Re: [Mesa-dev] [PATCH 01/12] vl: add parameters for VAAPI encode

2016-07-01 Thread Christian König
Hi Boyuan, as Emil wrote as well try to add some commit messages to the set. For this patch something like the following should do it: Allow to specify more parameters in the encoding interface which where previously just hardcoded in the encoder. Additional to that we need to reorder the p

Re: [Mesa-dev] [PATCH 01/12] vl: add parameters for VAAPI encode

2016-07-01 Thread Emil Velikov
Hi Boyuan, I believe Christian already mentioned this - here (and other patches really) you want to mention "why we want this". Something like "VAAPI does not allow for XX and YY. And requires the driver to explicitly manage/provide ZZ" will be more than enough imho. In general I would suggest be

[Mesa-dev] [PATCH 01/12] vl: add parameters for VAAPI encode

2016-06-30 Thread Boyuan Zhang
Signed-off-by: Boyuan Zhang --- src/gallium/include/pipe/p_video_state.h | 36 1 file changed, 36 insertions(+) diff --git a/src/gallium/include/pipe/p_video_state.h b/src/gallium/include/pipe/p_video_state.h index d353be6..9cd489b 100644 --- a/src/gallium/inclu