Re: [Mesa-dev] [PATCH 01/11] spirv: Handle tessellation execution modes.

2017-01-09 Thread Jason Ekstrand
On Sun, Jan 8, 2017 at 9:26 PM, Kenneth Graunke wrote: > Signed-off-by: Kenneth Graunke > --- > src/compiler/spirv/spirv_to_nir.c | 28 ++-- > 1 file changed, 22 insertions(+), 6 deletions(-) > > One totally bogus thing here: we set CCW backwards. In all three driver >

Re: [Mesa-dev] [PATCH 01/11] spirv: Handle tessellation execution modes.

2017-01-09 Thread Iago Toral
Patches 1-5 are: Reviewed-by: Iago Toral Quiroga On Sun, 2017-01-08 at 21:26 -0800, Kenneth Graunke wrote: > Signed-off-by: Kenneth Graunke > --- >  src/compiler/spirv/spirv_to_nir.c | 28 ++-- >  1 file changed, 22 insertions(+), 6 deletions(-) > > One totally bogus thin

Re: [Mesa-dev] [PATCH 01/11] spirv: Handle tessellation execution modes.

2017-01-08 Thread Dave Airlie
On 9 January 2017 at 15:26, Kenneth Graunke wrote: > Signed-off-by: Kenneth Graunke > --- > src/compiler/spirv/spirv_to_nir.c | 28 ++-- > 1 file changed, 22 insertions(+), 6 deletions(-) > > One totally bogus thing here: we set CCW backwards. In all three driver > backe

[Mesa-dev] [PATCH 01/11] spirv: Handle tessellation execution modes.

2017-01-08 Thread Kenneth Graunke
Signed-off-by: Kenneth Graunke --- src/compiler/spirv/spirv_to_nir.c | 28 ++-- 1 file changed, 22 insertions(+), 6 deletions(-) One totally bogus thing here: we set CCW backwards. In all three driver backends (i965, nvc0, radeonsi), we invert CCW because it doesn't seem