Re: [Mesa-dev] [PATCH 01/11] mesa: Compute effective buffer bindings in the vao.

2018-05-08 Thread Mathias Fröhlich
Hi Paul, On Wednesday, 9 May 2018 04:22:39 CEST Brian Paul wrote: > Minor nit-picks below and on patches 4 and 11. I skimmed the i965 > changes, but otherwise everything looks OK AFAICT. > > Nice work! > > Reviewed-by: Brian Paul I will update the patches. Thanks for the review! best Mathia

Re: [Mesa-dev] [PATCH 01/11] mesa: Compute effective buffer bindings in the vao.

2018-05-08 Thread Brian Paul
Minor nit-picks below and on patches 4 and 11. I skimmed the i965 changes, but otherwise everything looks OK AFAICT. Nice work! Reviewed-by: Brian Paul On 05/07/2018 12:14 AM, mathias.froehl...@gmx.net wrote: From: Mathias Fröhlich Compute VAO buffer binding information past the position

[Mesa-dev] [PATCH 01/11] mesa: Compute effective buffer bindings in the vao.

2018-05-06 Thread Mathias . Froehlich
From: Mathias Fröhlich Compute VAO buffer binding information past the position/generic0 mapping. Scan for duplicate buffer bindings and collapse them into derived effective buffer binding index and effective attribute mask variables. Provide a set of helper functions to access the distilled info

[Mesa-dev] [PATCH 01/11] mesa: Compute effective buffer bindings in the vao.

2018-04-01 Thread Mathias . Froehlich
From: Mathias Fröhlich Compute VAO buffer binding information past the position/generic0 mapping. Also scan for duplicate buffer bindings and collapse them into derived effective buffer binding index and effective attribute mask variables. Also provide a set of helper functions to access the dist