Re: [Mesa-dev] [PATCH 01/10] gallivm: supply correct opcode info to emit functions

2015-10-11 Thread Roland Scheidegger
Am 12.10.2015 um 00:55 schrieb Marek Olšák: > On Sun, Oct 11, 2015 at 11:15 PM, Roland Scheidegger > wrote: >> So why do you need to set the info back after action->emit? If you want >> to set that always so that information can be used, looks fine to me. >> But if you have to set it back afterwa

Re: [Mesa-dev] [PATCH 01/10] gallivm: supply correct opcode info to emit functions

2015-10-11 Thread Marek Olšák
On Sun, Oct 11, 2015 at 11:15 PM, Roland Scheidegger wrote: > So why do you need to set the info back after action->emit? If you want > to set that always so that information can be used, looks fine to me. > But if you have to set it back afterwards that screams hack (and I see > no reason for suc

Re: [Mesa-dev] [PATCH 01/10] gallivm: supply correct opcode info to emit functions

2015-10-11 Thread Roland Scheidegger
Am 11.10.2015 um 12:39 schrieb Marek Olšák: > On Sun, Oct 11, 2015 at 4:22 AM, Roland Scheidegger > wrote: >> Am 11.10.2015 um 03:29 schrieb Marek Olšák: >>> From: Marek Olšák >>> >>> This is useful only when emit functions use it. >>> The new radeonsi min/max opcode implementation requires this

Re: [Mesa-dev] [PATCH 01/10] gallivm: supply correct opcode info to emit functions

2015-10-11 Thread Marek Olšák
On Sun, Oct 11, 2015 at 4:22 AM, Roland Scheidegger wrote: > Am 11.10.2015 um 03:29 schrieb Marek Olšák: >> From: Marek Olšák >> >> This is useful only when emit functions use it. >> The new radeonsi min/max opcode implementation requires this. >> --- >> src/gallium/auxiliary/gallivm/lp_bld_tgsi

Re: [Mesa-dev] [PATCH 01/10] gallivm: supply correct opcode info to emit functions

2015-10-10 Thread Roland Scheidegger
Am 11.10.2015 um 03:29 schrieb Marek Olšák: > From: Marek Olšák > > This is useful only when emit functions use it. > The new radeonsi min/max opcode implementation requires this. > --- > src/gallium/auxiliary/gallivm/lp_bld_tgsi.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/s

[Mesa-dev] [PATCH 01/10] gallivm: supply correct opcode info to emit functions

2015-10-10 Thread Marek Olšák
From: Marek Olšák This is useful only when emit functions use it. The new radeonsi min/max opcode implementation requires this. --- src/gallium/auxiliary/gallivm/lp_bld_tgsi.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/gallium/auxiliary/gallivm/lp_bld_tgsi.c b/src/gallium/auxi