Re: [Mesa-dev] [PATCH 00/61] nir: Move to using instructions for derefs

2018-03-29 Thread Jason Ekstrand
On March 29, 2018 06:44:59 Rob Clark wrote: On Wed, Mar 28, 2018 at 9:41 PM, Jason Ekstrand wrote: On March 28, 2018 17:43:31 Rob Clark wrote: On Wed, Mar 28, 2018 at 8:16 PM, Jason Ekstrand wrote: On March 28, 2018 16:54:33 Rob Clark wrote: I had noticed the code to remove dead deref's i

Re: [Mesa-dev] [PATCH 00/61] nir: Move to using instructions for derefs

2018-03-29 Thread Rob Clark
On Wed, Mar 28, 2018 at 9:41 PM, Jason Ekstrand wrote: > > On March 28, 2018 17:43:31 Rob Clark wrote: > > On Wed, Mar 28, 2018 at 8:16 PM, Jason Ekstrand > wrote: > On March 28, 2018 16:54:33 Rob Clark wrote: > > I had noticed the code to remove dead deref's in a few of the passes > (at least

Re: [Mesa-dev] [PATCH 00/61] nir: Move to using instructions for derefs

2018-03-28 Thread Jason Ekstrand
On March 28, 2018 17:43:31 Rob Clark wrote: On Wed, Mar 28, 2018 at 8:16 PM, Jason Ekstrand wrote: On March 28, 2018 16:54:33 Rob Clark wrote: I had noticed the code to remove dead deref's in a few of the passes (at least on your wip branch), and had wondered a bit about not just requiring a

Re: [Mesa-dev] [PATCH 00/61] nir: Move to using instructions for derefs

2018-03-28 Thread Rob Clark
On Wed, Mar 28, 2018 at 8:16 PM, Jason Ekstrand wrote: > On March 28, 2018 16:54:33 Rob Clark wrote: > > I had noticed the code to remove dead deref's in a few of the passes > (at least on your wip branch), and had wondered a bit about not just > requiring all the deref related lowering to happen

Re: [Mesa-dev] [PATCH 00/61] nir: Move to using instructions for derefs

2018-03-28 Thread Jason Ekstrand
On March 28, 2018 16:54:33 Rob Clark wrote: I had noticed the code to remove dead deref's in a few of the passes (at least on your wip branch), and had wondered a bit about not just requiring all the deref related lowering to happen in ssa and possibly require dce after, although admittedly hadn

Re: [Mesa-dev] [PATCH 00/61] nir: Move to using instructions for derefs

2018-03-28 Thread Rob Clark
I had noticed the code to remove dead deref's in a few of the passes (at least on your wip branch), and had wondered a bit about not just requiring all the deref related lowering to happen in ssa and possibly require dce after, although admittedly hadn't thought about it *too* much yet.. I kinda e

Re: [Mesa-dev] [PATCH 00/61] nir: Move to using instructions for derefs

2018-03-28 Thread Jason Ekstrand
One interesting and unexpected side effect of this series has been that dead code elimination is now required to clean up unused deref instructions. This can be a problem for passes which alter and/or delete the variable because they may leave invalid deref instructions lying around. This is

Re: [Mesa-dev] [PATCH 00/61] nir: Move to using instructions for derefs

2018-03-23 Thread Jason Ekstrand
On Fri, Mar 23, 2018 at 2:42 PM, Jason Ekstrand wrote: > This is something that Connor and I have been talking about for some time > now. The basic idea is to replace the current singly linked nir_deref list > with deref instructions. This is similar to what LLVM does and it offers > quite a bi

[Mesa-dev] [PATCH 00/61] nir: Move to using instructions for derefs

2018-03-23 Thread Jason Ekstrand
This is something that Connor and I have been talking about for some time now. The basic idea is to replace the current singly linked nir_deref list with deref instructions. This is similar to what LLVM does and it offers quite a bit more freedom when we start getting more realistic pointers from