Re: [Mesa-dev] [PATCH 00/24] i965: Refactor register classes

2015-11-13 Thread Matt Turner
On Wed, Nov 11, 2015 at 3:20 PM, Kenneth Graunke wrote: > On Monday, November 02, 2015 04:29:10 PM Matt Turner wrote: >> backend_reg (from which fs_reg, src_reg, and dst_reg inherit) includes a >> brw_reg that's used for "hardware regs" -- precolored registers or >> architecture >> registers. Thi

Re: [Mesa-dev] [PATCH 00/24] i965: Refactor register classes

2015-11-11 Thread Kenneth Graunke
On Monday, November 02, 2015 04:29:10 PM Matt Turner wrote: > backend_reg (from which fs_reg, src_reg, and dst_reg inherit) includes a > brw_reg that's used for "hardware regs" -- precolored registers or > architecture > registers. This leads to properties like source modifiers, the register type,

Re: [Mesa-dev] [PATCH 00/24] i965: Refactor register classes

2015-11-06 Thread Emil Velikov
Hi Matt, A short summary [PATCH 06/24] i965: Add and use enum brw_reg_file. s/GRF/BRW_ARCHITECTURE_REGISTER_FILE/ - already addressed in your branch. [PATCH 12/24] i965: Initialize registers' file to BAD_FILE. With the fs_visitor::init() hunk dropped and memset(this->outputs, 0...) removed.

Re: [Mesa-dev] [PATCH 00/24] i965: Refactor register classes

2015-11-03 Thread Emil Velikov
Hi Matt, On 3 November 2015 at 00:29, Matt Turner wrote: > backend_reg (from which fs_reg, src_reg, and dst_reg inherit) includes a > brw_reg that's used for "hardware regs" -- precolored registers or > architecture > registers. This leads to properties like source modifiers, the register type,

[Mesa-dev] [PATCH 00/24] i965: Refactor register classes

2015-11-02 Thread Matt Turner
backend_reg (from which fs_reg, src_reg, and dst_reg inherit) includes a brw_reg that's used for "hardware regs" -- precolored registers or architecture registers. This leads to properties like source modifiers, the register type, swizzles, and writemasks being duplicated between the derived classe