Re: [Mesa-dev] [PATCH 00/18] Multi-stream support for geometry shaders

2014-06-16 Thread Ilia Mirkin
On Mon, Jun 16, 2014 at 1:20 PM, Jordan Justen wrote: > On Mon, Jun 16, 2014 at 1:05 AM, Samuel Iglesias Gonsálvez > wrote: >> On Sun, 2014-06-15 at 19:18 -0400, Ilia Mirkin wrote: >>> On Wed, Jun 11, 2014 at 12:31 PM, Jordan Justen wrote: >>> > On Wed, Jun 11, 2014 at 2:49 AM, Iago Toral wrote

Re: [Mesa-dev] [PATCH 00/18] Multi-stream support for geometry shaders

2014-06-16 Thread Jordan Justen
On Mon, Jun 16, 2014 at 1:05 AM, Samuel Iglesias Gonsálvez wrote: > On Sun, 2014-06-15 at 19:18 -0400, Ilia Mirkin wrote: >> On Wed, Jun 11, 2014 at 12:31 PM, Jordan Justen wrote: >> > On Wed, Jun 11, 2014 at 2:49 AM, Iago Toral wrote: >> >> Hi Chris, >> >> >> >> thanks for the quick review! >>

Re: [Mesa-dev] [PATCH 00/18] Multi-stream support for geometry shaders

2014-06-16 Thread Samuel Iglesias Gonsálvez
On Sun, 2014-06-15 at 19:18 -0400, Ilia Mirkin wrote: > On Wed, Jun 11, 2014 at 12:31 PM, Jordan Justen wrote: > > On Wed, Jun 11, 2014 at 2:49 AM, Iago Toral wrote: > >> Hi Chris, > >> > >> thanks for the quick review! > >> > >> On Wed, 2014-06-11 at 21:45 +1200, Chris Forbes wrote: > >>> I sent

Re: [Mesa-dev] [PATCH 00/18] Multi-stream support for geometry shaders

2014-06-15 Thread Ilia Mirkin
On Wed, Jun 11, 2014 at 12:31 PM, Jordan Justen wrote: > On Wed, Jun 11, 2014 at 2:49 AM, Iago Toral wrote: >> Hi Chris, >> >> thanks for the quick review! >> >> On Wed, 2014-06-11 at 21:45 +1200, Chris Forbes wrote: >>> I sent comments on patches 1, 3, 5, 9, 11, 16, 18 >> >> We will look into th

Re: [Mesa-dev] [PATCH 00/18] Multi-stream support for geometry shaders

2014-06-11 Thread Jordan Justen
On Wed, Jun 11, 2014 at 2:49 AM, Iago Toral wrote: > Hi Chris, > > thanks for the quick review! > > On Wed, 2014-06-11 at 21:45 +1200, Chris Forbes wrote: >> I sent comments on patches 1, 3, 5, 9, 11, 16, 18 > > We will look into these. > >> Patches 2, 4, 6-8, 10, 12-15, 17 are: >> >> Reviewed-by:

Re: [Mesa-dev] [PATCH 00/18] Multi-stream support for geometry shaders

2014-06-11 Thread Iago Toral
Hi Chris, thanks for the quick review! On Wed, 2014-06-11 at 21:45 +1200, Chris Forbes wrote: > I sent comments on patches 1, 3, 5, 9, 11, 16, 18 We will look into these. > Patches 2, 4, 6-8, 10, 12-15, 17 are: > > Reviewed-by: Chris Forbes > > You should also include a patch to docs/GL3.txt

Re: [Mesa-dev] [PATCH 00/18] Multi-stream support for geometry shaders

2014-06-11 Thread Chris Forbes
I sent comments on patches 1, 3, 5, 9, 11, 16, 18 Patches 2, 4, 6-8, 10, 12-15, 17 are: Reviewed-by: Chris Forbes You should also include a patch to docs/GL3.txt marking off this subfeature for i965 :) Do you have a bunch of piglits which exercise all the tricky corners of this? I see a few t

[Mesa-dev] [PATCH 00/18] Multi-stream support for geometry shaders

2014-06-11 Thread Iago Toral Quiroga
This series brings multi-stream support to geometry shaders as defined by ARB_gpu_shader5. It also covers some missing multi-stream functionality from ARB_transform_feedback3. This is combined work from Samuel Iglesias and myself. The series includes both required infrastructure in Mesa and specif