Re: [Mesa-dev] [PATCH 00/10] gallium: normalize CONST file accesses to 2D - 2. try without image for the list

2017-08-25 Thread Dieter Nützel
Brave man, with the little 'squash! st/glsl_to_tgsi: inline src_register into translate_src' on top of your series, both issues are _solved_. So you have my Tested-by: Dieter Nützel for the series. BTW Running this together with: Prehash-all-the-things.mbox (Thomas Helland) mesa-st-glsl_to

Re: [Mesa-dev] [PATCH 00/10] gallium: normalize CONST file accesses to 2D - 2. try without image for the list

2017-08-25 Thread Nicolai Hähnle
Hi Dieter, sorry for the churn -- do these issues also occur with the latest addition to https://cgit.freedesktop.org/~nh/mesa/log/?h=tgsi-const-2d? Cheers, Nicolai On 25.08.2017 08:19, Dieter Nützel wrote: Am 25.08.2017 07:38, schrieb Dieter Nützel: Am 23.08.2017 18:41, schrieb Nicolai Häh

Re: [Mesa-dev] [PATCH 00/10] gallium: normalize CONST file accesses to 2D - 2. try without image for the list

2017-08-24 Thread Dieter Nützel
Am 25.08.2017 07:38, schrieb Dieter Nützel: Am 23.08.2017 18:41, schrieb Nicolai Hähnle: Hi all, Following the discussion on Timothy's std430 packing series, here's a quick proposal to just always use 2D accesses to the CONST file in TGSI. The first patch should be sufficient for all drivers t

Re: [Mesa-dev] [PATCH 00/10] gallium: normalize CONST file accesses to 2D

2017-08-24 Thread Dieter Nützel
Am 23.08.2017 18:41, schrieb Nicolai Hähnle: Hi all, Following the discussion on Timothy's std430 packing series, here's a quick proposal to just always use 2D accesses to the CONST file in TGSI. The first patch should be sufficient for all drivers to accept those 2D accesses. It seems that mos

Re: [Mesa-dev] [PATCH 00/10] gallium: normalize CONST file accesses to 2D

2017-08-24 Thread Roland Scheidegger
We'll definitely have to adjust some code too, but looks alright to me. For the series: Acked-by: Roland Scheidegger Am 23.08.2017 um 18:41 schrieb Nicolai Hähnle: > Hi all, > > Following the discussion on Timothy's std430 packing series, here's > a quick proposal to just always use 2D accesses

[Mesa-dev] [PATCH 00/10] gallium: normalize CONST file accesses to 2D

2017-08-23 Thread Nicolai Hähnle
Hi all, Following the discussion on Timothy's std430 packing series, here's a quick proposal to just always use 2D accesses to the CONST file in TGSI. The first patch should be sufficient for all drivers to accept those 2D accesses. It seems that most older drivers simply ignore the dimension, an