Re: [Mesa-dev] [PATCH 0/5] i965: die structs die!

2011-07-07 Thread Kenneth Graunke
On 07/07/2011 01:12 AM, Zou, Nanhai wrote: Hi, What is the intention of switching struct-style command to OUT_BATCH style? Thanks Zou Nanhai Several reasons: 1) Better code generation. Eric has told me that GCC generates pretty sub-optimal code for packed-bit structs, and using OUT

Re: [Mesa-dev] [PATCH 0/5] i965: die structs die!

2011-07-07 Thread Zou, Nanhai
rg] On >>Behalf Of Kenneth Graunke >>Sent: 2011年7月7日 15:49 >>To: mesa-dev@lists.freedesktop.org >>Subject: [Mesa-dev] [PATCH 0/5] i965: die structs die! >> >>This patch series converts a few of the remaining struct-style command >>submissions to OUT_BATCH styl

[Mesa-dev] [PATCH 0/5] i965: die structs die!

2011-07-07 Thread Kenneth Graunke
This patch series converts a few of the remaining struct-style command submissions to OUT_BATCH style and then removes a ton of unused structs. Keeping the structures in the codebase is misleading, since (a) you might presume that they're actually used for something (they aren't), and (b) they may