Re: [Mesa-dev] [PATCH 0/5] R600, GCN: Guard Band support

2016-04-11 Thread Nicolai Hähnle
Assuming that this has been tested, and with comments on patch #2 addressed, Reviewed-by: Nicolai Hähnle On 10.04.2016 17:34, Marek Olšák wrote: Hi, This patch series adds Guard Band support into r600g and radeonsi. It first implements the Guard Band in radeonsi, then it moves all radeonsi s

Re: [Mesa-dev] [PATCH 0/5] R600, GCN: Guard Band support

2016-04-11 Thread Kristian Høgsberg
On Sun, Apr 10, 2016 at 10:23 PM, wrote: > I didn't see anything obviously wrong so, > > Reviewed-by: Edward O'Callaghan > > But I have some general questions about guard band, not sure if this is the > right place but I'll just ask any way: > From my somewhat naive understanding guard band can

Re: [Mesa-dev] [PATCH 0/5] R600, GCN: Guard Band support

2016-04-11 Thread Grigori Goronzy
On 2016-04-11 00:34, Marek Olšák wrote: This patch series adds Guard Band support into r600g and radeonsi. It first implements the Guard Band in radeonsi, then it moves all radeonsi scissor & viewport code into gallium/radeon, and then r600g is switched to it and its original scissor & viewport

Re: [Mesa-dev] [PATCH 0/5] R600, GCN: Guard Band support

2016-04-11 Thread Roland Scheidegger
Am 11.04.2016 um 15:58 schrieb Marek Olšák: > On Mon, Apr 11, 2016 at 2:41 PM, Roland Scheidegger > wrote: >> Am 11.04.2016 um 00:34 schrieb Marek Olšák: >>> Hi, >>> >>> This patch series adds Guard Band support into r600g and radeonsi. >>> >>> It first implements the Guard Band in radeonsi, then

Re: [Mesa-dev] [PATCH 0/5] R600, GCN: Guard Band support

2016-04-11 Thread Marek Olšák
On Mon, Apr 11, 2016 at 2:41 PM, Roland Scheidegger wrote: > Am 11.04.2016 um 00:34 schrieb Marek Olšák: >> Hi, >> >> This patch series adds Guard Band support into r600g and radeonsi. >> >> It first implements the Guard Band in radeonsi, then it moves all radeonsi >> scissor & viewport code into

Re: [Mesa-dev] [PATCH 0/5] R600, GCN: Guard Band support

2016-04-11 Thread Roland Scheidegger
Am 11.04.2016 um 00:34 schrieb Marek Olšák: > Hi, > > This patch series adds Guard Band support into r600g and radeonsi. > > It first implements the Guard Band in radeonsi, then it moves all radeonsi > scissor & viewport code into gallium/radeon, and then r600g is switched to it > and its origi

Re: [Mesa-dev] [PATCH 0/5] R600, GCN: Guard Band support

2016-04-11 Thread Marek Olšák
On Mon, Apr 11, 2016 at 7:23 AM, wrote: > I didn't see anything obviously wrong so, > > Reviewed-by: Edward O'Callaghan > > But I have some general questions about guard band, not sure if this is the > right place but I'll just ask any way: > From my somewhat naive understanding guard band can l

Re: [Mesa-dev] [PATCH 0/5] R600, GCN: Guard Band support

2016-04-10 Thread eocallaghan
I didn't see anything obviously wrong so, Reviewed-by: Edward O'Callaghan But I have some general questions about guard band, not sure if this is the right place but I'll just ask any way: From my somewhat naive understanding guard band can lead to small gaps between polygons. In this impleme

[Mesa-dev] [PATCH 0/5] R600, GCN: Guard Band support

2016-04-10 Thread Marek Olšák
Hi, This patch series adds Guard Band support into r600g and radeonsi. It first implements the Guard Band in radeonsi, then it moves all radeonsi scissor & viewport code into gallium/radeon, and then r600g is switched to it and its original scissor & viewport code is deleted. The differences b