Re: [Mesa-dev] [PATCH 0/4] fence refcnting fixes

2015-07-09 Thread Rob Clark
On Thu, Jul 9, 2015 at 4:21 AM, Christian König wrote: > On 08.07.2015 22:34, Rob Clark wrote: >> >> From: Rob Clark >> >> This isn't at all clear for pipe driver writers currently, since it >> is not documented anywhere. But radeon/nouveau/llvmpipe seem to drop >> the ref on the **fence passed

Re: [Mesa-dev] [PATCH 0/4] fence refcnting fixes

2015-07-09 Thread Christian König
On 08.07.2015 22:34, Rob Clark wrote: From: Rob Clark This isn't at all clear for pipe driver writers currently, since it is not documented anywhere. But radeon/nouveau/llvmpipe seem to drop the ref on the **fence passed in to pipe->flush() (if *fence!=NULL). Freedreno/ilo/vc4 where not doing

Re: [Mesa-dev] [PATCH 0/4] fence refcnting fixes

2015-07-08 Thread Rob Clark
Bleh, assert(pipe_is_referenced(ptr)) in pipe_reference_described() is non-pleased in debug builds about the trick of starting out the fences w/ refcnt=0 (so that it doesn't end up getting upref'd to 2 in pipe->flush().. so I'll have to re-work the fd/ilo/vc4 patches slightly.. BR, -R On Wed, Jul

[Mesa-dev] [PATCH 0/4] fence refcnting fixes

2015-07-08 Thread Rob Clark
From: Rob Clark This isn't at all clear for pipe driver writers currently, since it is not documented anywhere. But radeon/nouveau/llvmpipe seem to drop the ref on the **fence passed in to pipe->flush() (if *fence!=NULL). Freedreno/ilo/vc4 where not doing this. Some state trackers do call scree