Re: [Mesa-dev] [PATCH 0/3] verify max vertex attrib stride

2018-07-09 Thread Roland Scheidegger
Am 09.07.2018 um 09:54 schrieb Erik Faye-Lund: > On 06. juli 2018 18:43, Roland Scheidegger wrote: >> Am 06.07.2018 um 12:03 schrieb Erik Faye-Lund: >>> OpenGL 4.4 and OpenGL ES 3.1 both require the maximum >>> vertex attrib stride to be at least 2048. If this isn't >>> the case, we shouldn't expos

Re: [Mesa-dev] [PATCH 0/3] verify max vertex attrib stride

2018-07-09 Thread Roland Scheidegger
Am 09.07.2018 um 11:51 schrieb Gert Wollny: > Am Montag, den 09.07.2018, 09:54 +0200 schrieb Erik Faye-Lund: >> On 06. juli 2018 18:43, Roland Scheidegger wrote: >>> >>> Personally I think it's _much_ better to lie about the supported GL >>> version rather than the maximum vertex attrib stride (I d

Re: [Mesa-dev] [PATCH 0/3] verify max vertex attrib stride

2018-07-09 Thread Gert Wollny
Am Montag, den 09.07.2018, 09:54 +0200 schrieb Erik Faye-Lund: > On 06. juli 2018 18:43, Roland Scheidegger wrote: > > > > Personally I think it's _much_ better to lie about the supported GL > > version rather than the maximum vertex attrib stride (I don't know > > if dEQP would actually have a te

Re: [Mesa-dev] [PATCH 0/3] verify max vertex attrib stride

2018-07-09 Thread Erik Faye-Lund
On 06. juli 2018 18:43, Roland Scheidegger wrote: Am 06.07.2018 um 12:03 schrieb Erik Faye-Lund: OpenGL 4.4 and OpenGL ES 3.1 both require the maximum vertex attrib stride to be at least 2048. If this isn't the case, we shouldn't expose these API versions. Unfortunately, the r600 driver only su

Re: [Mesa-dev] [PATCH 0/3] verify max vertex attrib stride

2018-07-06 Thread Ian Romanick
On 07/06/2018 09:43 AM, Roland Scheidegger wrote: > Am 06.07.2018 um 12:03 schrieb Erik Faye-Lund: >> OpenGL 4.4 and OpenGL ES 3.1 both require the maximum >> vertex attrib stride to be at least 2048. If this isn't >> the case, we shouldn't expose these API versions. >> >> Unfortunately, the r600 d

Re: [Mesa-dev] [PATCH 0/3] verify max vertex attrib stride

2018-07-06 Thread Ian Romanick
Assuming the concerns about patch 1 are resolved, patches 2 and 3 are Reviewed-by: Ian Romanick On 07/06/2018 03:03 AM, Erik Faye-Lund wrote: > OpenGL 4.4 and OpenGL ES 3.1 both require the maximum > vertex attrib stride to be at least 2048. If this isn't > the case, we shouldn't expose these AP

Re: [Mesa-dev] [PATCH 0/3] verify max vertex attrib stride

2018-07-06 Thread Roland Scheidegger
Am 06.07.2018 um 12:03 schrieb Erik Faye-Lund: > OpenGL 4.4 and OpenGL ES 3.1 both require the maximum > vertex attrib stride to be at least 2048. If this isn't > the case, we shouldn't expose these API versions. > > Unfortunately, the r600 driver only supports 2047. To > avoid regressions in the

[Mesa-dev] [PATCH 0/3] verify max vertex attrib stride

2018-07-06 Thread Erik Faye-Lund
OpenGL 4.4 and OpenGL ES 3.1 both require the maximum vertex attrib stride to be at least 2048. If this isn't the case, we shouldn't expose these API versions. Unfortunately, the r600 driver only supports 2047. To avoid regressions in the supported GL version, the first patch modifies the returned