Re: [Mesa-dev] [PATCH] vulkan/wsi: Only use LINEAR modifier for prime if supported.

2018-05-08 Thread Daniel Stone
On 5 May 2018 at 14:34, Bas Nieuwenhuizen wrote: > This was setting the LINEAR modifier if neither the > X server nor the driver supported modifiers. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106180 > Fixes: c80c08e226 "vulkan/wsi/x11: Add support for DRI3 v1.2" > CC: 18.1 > CC:

Re: [Mesa-dev] [PATCH] vulkan/wsi: Only use LINEAR modifier for prime if supported.

2018-05-08 Thread Abel García Dorta
This patch has been Tested-by: Abel Garcia Dorta on top of master and on top of mesa-18.1.0_rc2 provided by gentoo. Thank you for fixing it! 2018-05-05 15:34 GMT+02:00 Bas Nieuwenhuizen : > This was setting the LINEAR modifier if neither the > X server nor the driver supported modifiers. > >

Re: [Mesa-dev] [PATCH] vulkan/wsi: Only use LINEAR modifier for prime if supported.

2018-05-07 Thread Abel García Dorta
Hi, I sent a similar patch yesterday with: + if (chain->has_dri3_modifiers && + image->base.drm_modifier != DRM_FORMAT_MOD_INVALID) { but was rejected by bas and never got into the mail list... If the jason's patch is going to be the good patch I would like to have some aknowlegment in th

Re: [Mesa-dev] [PATCH] vulkan/wsi: Only use LINEAR modifier for prime if supported.

2018-05-06 Thread Jason Ekstrand
Rb On May 5, 2018 06:35:46 Bas Nieuwenhuizen wrote: This was setting the LINEAR modifier if neither the X server nor the driver supported modifiers. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106180 Fixes: c80c08e226 "vulkan/wsi/x11: Add support for DRI3 v1.2" CC: 18.1 CC: Abel G

Re: [Mesa-dev] [PATCH] vulkan/wsi: Only use LINEAR modifier for prime if supported.

2018-05-06 Thread Jason Ekstrand
On May 6, 2018 05:58:52 Daniel Stone wrote: Hi, On 5 May 2018 at 19:07, Jason Ekstrand wrote: On Sat, May 5, 2018 at 6:34 AM, Bas Nieuwenhuizen wrote: @@ -1043,7 +1043,8 @@ x11_image_init(VkDevice device_h, struct x11_swapchain *chain, uint32_t bpp = 32; if (chain->base.use_prime_blit)

Re: [Mesa-dev] [PATCH] vulkan/wsi: Only use LINEAR modifier for prime if supported.

2018-05-06 Thread Daniel Stone
Hi, On 5 May 2018 at 19:07, Jason Ekstrand wrote: > On Sat, May 5, 2018 at 6:34 AM, Bas Nieuwenhuizen > wrote: >> @@ -1043,7 +1043,8 @@ x11_image_init(VkDevice device_h, struct >> x11_swapchain *chain, >> uint32_t bpp = 32; >> >> if (chain->base.use_prime_blit) { >> - result = wsi_

Re: [Mesa-dev] [PATCH] vulkan/wsi: Only use LINEAR modifier for prime if supported.

2018-05-05 Thread Jason Ekstrand
On Sat, May 5, 2018 at 6:34 AM, Bas Nieuwenhuizen wrote: > This was setting the LINEAR modifier if neither the > X server nor the driver supported modifiers. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106180 > Fixes: c80c08e226 "vulkan/wsi/x11: Add support for DRI3 v1.2" > CC: 18.

[Mesa-dev] [PATCH] vulkan/wsi: Only use LINEAR modifier for prime if supported.

2018-05-05 Thread Bas Nieuwenhuizen
This was setting the LINEAR modifier if neither the X server nor the driver supported modifiers. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106180 Fixes: c80c08e226 "vulkan/wsi/x11: Add support for DRI3 v1.2" CC: 18.1 CC: Abel Garcia Dorta CC: Daniel Stone --- src/vulkan/wsi/wsi_co