Re: [Mesa-dev] [PATCH] virgl: Support ARB_framebuffer_no_attachments

2018-06-28 Thread Emil Velikov
On 28 June 2018 at 17:16, Drew Davenport wrote: > On Wed, Jun 27, 2018 at 1:57 AM Emil Velikov wrote: >> >> On 27 June 2018 at 09:55, Emil Velikov wrote: >> > Hi Drew, >> > >> > Just some food for thought. The patch in itself looks correct albeit >> > partial. >> > >> > On 27 June 2018 at 00:00

Re: [Mesa-dev] [PATCH] virgl: Support ARB_framebuffer_no_attachments

2018-06-28 Thread Drew Davenport
On Wed, Jun 27, 2018 at 6:47 AM Ilia Mirkin wrote: > > On Tue, Jun 26, 2018 at 7:00 PM, Drew Davenport > wrote: > > This change lets the following test pass on virgl: > > dEQP-GLES31.functional.state_query.framebuffer_default.framebuffer_default_samples_get_framebuffer_parameteriv > > --- > > s

Re: [Mesa-dev] [PATCH] virgl: Support ARB_framebuffer_no_attachments

2018-06-28 Thread Drew Davenport
On Wed, Jun 27, 2018 at 1:57 AM Emil Velikov wrote: > > On 27 June 2018 at 09:55, Emil Velikov wrote: > > Hi Drew, > > > > Just some food for thought. The patch in itself looks correct albeit > > partial. > > > > On 27 June 2018 at 00:00, Drew Davenport wrote: > >> This change lets the followin

Re: [Mesa-dev] [PATCH] virgl: Support ARB_framebuffer_no_attachments

2018-06-27 Thread Ilia Mirkin
On Tue, Jun 26, 2018 at 7:00 PM, Drew Davenport wrote: > This change lets the following test pass on virgl: > dEQP-GLES31.functional.state_query.framebuffer_default.framebuffer_default_samples_get_framebuffer_parameteriv > --- > src/gallium/drivers/virgl/virgl_screen.c | 4 > 1 file changed,

Re: [Mesa-dev] [PATCH] virgl: Support ARB_framebuffer_no_attachments

2018-06-27 Thread Emil Velikov
On 27 June 2018 at 09:55, Emil Velikov wrote: > Hi Drew, > > Just some food for thought. The patch in itself looks correct albeit partial. > > On 27 June 2018 at 00:00, Drew Davenport wrote: >> This change lets the following test pass on virgl: >> dEQP-GLES31.functional.state_query.framebuffer_de

Re: [Mesa-dev] [PATCH] virgl: Support ARB_framebuffer_no_attachments

2018-06-27 Thread Emil Velikov
Hi Drew, Just some food for thought. The patch in itself looks correct albeit partial. On 27 June 2018 at 00:00, Drew Davenport wrote: > This change lets the following test pass on virgl: > dEQP-GLES31.functional.state_query.framebuffer_default.framebuffer_default_samples_get_framebuffer_paramet

[Mesa-dev] [PATCH] virgl: Support ARB_framebuffer_no_attachments

2018-06-26 Thread Drew Davenport
This change lets the following test pass on virgl: dEQP-GLES31.functional.state_query.framebuffer_default.framebuffer_default_samples_get_framebuffer_parameteriv --- src/gallium/drivers/virgl/virgl_screen.c | 4 1 file changed, 4 insertions(+) diff --git a/src/gallium/drivers/virgl/virgl_scr