Re: [Mesa-dev] [PATCH] vbo: introduce vbo_get_minmax_indices function

2012-01-11 Thread Brian Paul
On 01/11/2012 01:17 AM, Yuanhan Liu wrote: On Tue, Jan 10, 2012 at 08:43:18PM -0700, Brian Paul wrote: On Tue, Jan 3, 2012 at 8:59 PM, Yuanhan Liu wrote: On Wed, Jan 04, 2012 at 11:20:07AM +0800, Yuanhan Liu wrote: On Tue, Jan 03, 2012 at 08:25:31PM +0100, Roland Scheidegger wrote: Ah index

Re: [Mesa-dev] [PATCH] vbo: introduce vbo_get_minmax_indices function

2012-01-11 Thread Yuanhan Liu
On Tue, Jan 10, 2012 at 08:43:18PM -0700, Brian Paul wrote: > On Tue, Jan 3, 2012 at 8:59 PM, Yuanhan Liu > wrote: > > On Wed, Jan 04, 2012 at 11:20:07AM +0800, Yuanhan Liu wrote: > >> On Tue, Jan 03, 2012 at 08:25:31PM +0100, Roland Scheidegger wrote: > >> > Ah index scanning... > >> > I don't l

Re: [Mesa-dev] [PATCH] vbo: introduce vbo_get_minmax_indices function

2012-01-10 Thread Brian Paul
On Tue, Jan 3, 2012 at 8:59 PM, Yuanhan Liu wrote: > On Wed, Jan 04, 2012 at 11:20:07AM +0800, Yuanhan Liu wrote: >> On Tue, Jan 03, 2012 at 08:25:31PM +0100, Roland Scheidegger wrote: >> > Ah index scanning... >> > I don't like that this will map/unmap the ib once for each prim, >> Me either :) >

Re: [Mesa-dev] [PATCH] vbo: introduce vbo_get_minmax_indices function

2012-01-10 Thread Yuanhan Liu
On Wed, Jan 04, 2012 at 07:23:24PM +0100, Roland Scheidegger wrote: > Am 04.01.2012 04:59, schrieb Yuanhan Liu: > > On Wed, Jan 04, 2012 at 11:20:07AM +0800, Yuanhan Liu wrote: > >> On Tue, Jan 03, 2012 at 08:25:31PM +0100, Roland Scheidegger wrote: > >>> Ah index scanning... > >>> I don't like tha

Re: [Mesa-dev] [PATCH] vbo: introduce vbo_get_minmax_indices function

2012-01-04 Thread Roland Scheidegger
Am 04.01.2012 04:59, schrieb Yuanhan Liu: > On Wed, Jan 04, 2012 at 11:20:07AM +0800, Yuanhan Liu wrote: >> On Tue, Jan 03, 2012 at 08:25:31PM +0100, Roland Scheidegger wrote: >>> Ah index scanning... >>> I don't like that this will map/unmap the ib once for each prim, >> Me either :) >> >>> though

Re: [Mesa-dev] [PATCH] vbo: introduce vbo_get_minmax_indices function

2012-01-04 Thread Roland Scheidegger
Am 04.01.2012 04:20, schrieb Yuanhan Liu: > On Tue, Jan 03, 2012 at 08:25:31PM +0100, Roland Scheidegger wrote: >> Ah index scanning... >> I don't like that this will map/unmap the ib once for each prim, > Me either :) > >> though >> I don't really see a nice way to avoid that (I think if you have

Re: [Mesa-dev] [PATCH] vbo: introduce vbo_get_minmax_indices function

2012-01-03 Thread Yuanhan Liu
On Wed, Jan 04, 2012 at 11:20:07AM +0800, Yuanhan Liu wrote: > On Tue, Jan 03, 2012 at 08:25:31PM +0100, Roland Scheidegger wrote: > > Ah index scanning... > > I don't like that this will map/unmap the ib once for each prim, > Me either :) > > > though > > I don't really see a nice way to avoid th

Re: [Mesa-dev] [PATCH] vbo: introduce vbo_get_minmax_indices function

2012-01-03 Thread Yuanhan Liu
On Tue, Jan 03, 2012 at 08:25:31PM +0100, Roland Scheidegger wrote: > Ah index scanning... > I don't like that this will map/unmap the ib once for each prim, Me either :) > though > I don't really see a nice way to avoid that (I think if you have to Well, I thought a while, we may do some combine

Re: [Mesa-dev] [PATCH] vbo: introduce vbo_get_minmax_indices function

2012-01-03 Thread Roland Scheidegger
Ah index scanning... I don't like that this will map/unmap the ib once for each prim, though I don't really see a nice way to avoid that (I think if you have to actually map the ib, you lose anyway). Hopefully won't hit that performance hog often... A comment inline. Am 31.12.2011 07:32, schrieb

[Mesa-dev] [PATCH] vbo: introduce vbo_get_minmax_indices function

2011-12-30 Thread Yuanhan Liu
Introduce vbo_get_minmax_indices() function to handle the min/max index computation for nr_prims(>= 1). The old code just compute the first prim's min/max index; this would results an error rendering if user called functions like glMultiDrawElements(). This patch servers as fixing this issue. As w