Re: [Mesa-dev] [PATCH] vbo: fix glVertexAttrib(index=0)

2017-08-23 Thread Charmaine Lee
Looks good. Thanks. Reviewed-by: Charmaine Lee From: Brian Paul Sent: Tuesday, August 22, 2017 1:21:56 PM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee; Neha Bhende Subject: [PATCH] vbo: fix glVertexAttrib(index=0) Depending on which extension o

Re: [Mesa-dev] [PATCH] vbo: fix glVertexAttrib(index=0)

2017-08-23 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Tue, Aug 22, 2017 at 10:21 PM, Brian Paul wrote: > Depending on which extension or GL spec you read the behavior of > glVertexAttrib(index=0) either sets the current value for generic > attribute 0, or it emits a vertex just like glVertex(). I believe > it sho

[Mesa-dev] [PATCH] vbo: fix glVertexAttrib(index=0)

2017-08-22 Thread Brian Paul
Depending on which extension or GL spec you read the behavior of glVertexAttrib(index=0) either sets the current value for generic attribute 0, or it emits a vertex just like glVertex(). I believe it should do either, depending on context (see below). The piglit gl-2.0-vertex-const-attr test decl