Re: [Mesa-dev] [PATCH] utils/u_math: break dependency on gallium/utils

2018-09-20 Thread Dylan Baker
Sigh. Let me see if I can reproduce the failure with mingw, if we can't I'll revert patch. Dylan Quoting Roland Scheidegger (2018-09-20 07:13:11) > Looks like this broke the windows build, however. > > Roland > > Am 09.09.2018 um 08:39 schrieb Dylan Baker: > > Currently u_math needs gallium uti

Re: [Mesa-dev] [PATCH] utils/u_math: break dependency on gallium/utils

2018-09-20 Thread Roland Scheidegger
Looks like this broke the windows build, however. Roland Am 09.09.2018 um 08:39 schrieb Dylan Baker: > Currently u_math needs gallium utils for cpu detection. Most of what > u_math uses out of u_cpu_detection is duplicated in src/mesa/x86 > (surprise!), so I've just reworked it as much as possib

Re: [Mesa-dev] [PATCH] utils/u_math: break dependency on gallium/utils

2018-09-10 Thread Vinson Lee
On Sat, Sep 8, 2018 at 11:39 PM, Dylan Baker wrote: > Currently u_math needs gallium utils for cpu detection. Most of what > u_math uses out of u_cpu_detection is duplicated in src/mesa/x86 > (surprise!), so I've just reworked it as much as possible to use the > x86/common_x86_features macros ins

Re: [Mesa-dev] [PATCH] utils/u_math: break dependency on gallium/utils

2018-09-10 Thread Marek Olšák
On Mon, Sep 10, 2018 at 12:11 PM, Dylan Baker wrote: > I agree that using code from mesa in util is gross, I'm not planning to leave > it > like this. I'm in the middle of cleaning up duplication between util and mesa, > and I'll plan on pulling u_cpu_detection down into src/util in that series.

Re: [Mesa-dev] [PATCH] utils/u_math: break dependency on gallium/utils

2018-09-10 Thread Dylan Baker
I agree that using code from mesa in util is gross, I'm not planning to leave it like this. I'm in the middle of cleaning up duplication between util and mesa, and I'll plan on pulling u_cpu_detection down into src/util in that series. In this case while gross there shouldn't be any compilation is

Re: [Mesa-dev] [PATCH] utils/u_math: break dependency on gallium/utils

2018-09-09 Thread Marek Olšák
I think this will break non-GL gallium state trackers. src/mesa is only for GL, which is why common gallium code and gallium drivers can't use code from src/mesa. Marek On Sun, Sep 9, 2018 at 2:39 AM, Dylan Baker wrote: > Currently u_math needs gallium utils for cpu detection. Most of what > u_

[Mesa-dev] [PATCH] utils/u_math: break dependency on gallium/utils

2018-09-08 Thread Dylan Baker
Currently u_math needs gallium utils for cpu detection. Most of what u_math uses out of u_cpu_detection is duplicated in src/mesa/x86 (surprise!), so I've just reworked it as much as possible to use the x86/common_x86_features macros instead of the gallium ones. There is one small function that wa