Re: [Mesa-dev] [PATCH] util: fix off-by-one when loading source

2019-01-20 Thread Caio Marcelo de Oliveira Filho
On Sun, Jan 20, 2019 at 09:09:56AM +, Eric Engestrom wrote: > Yeah, I had that change locally, but didn't push it :] > > Reviewed-by: Eric Engestrom > > > > > 7c8ee3f0f "util: simplify string duplication logic" > > "Fixes:" ? Fixed "Fixes" and pushed :-) Caio ___

Re: [Mesa-dev] [PATCH] util: fix off-by-one when loading source

2019-01-20 Thread Eric Engestrom
On January 19, 2019 11:40:41 PM UTC, Caio Marcelo de Oliveira Filho wrote: > One extra character is leaking from the text into the copied line. > The "+ 1" is an artifact from when malloc was used, strndup will add > the extra '\0' after copying text_size bytes (if available). Yeah, I had that

Re: [Mesa-dev] [PATCH] util: fix off-by-one when loading source

2019-01-19 Thread Caio Marcelo de Oliveira Filho
Sorry for the wrong list. Sent again to piglit@. On Sat, Jan 19, 2019 at 03:40:01PM -0800, Caio Marcelo de Oliveira Filho wrote: > One extra character is leaking from the text into the copied line. > The "+ 1" is an artifact from when malloc was used, strndup will add > the extra '\0' after copyi

[Mesa-dev] [PATCH] util: fix off-by-one when loading source

2019-01-19 Thread Caio Marcelo de Oliveira Filho
One extra character is leaking from the text into the copied line. The "+ 1" is an artifact from when malloc was used, strndup will add the extra '\0' after copying text_size bytes (if available). 7c8ee3f0f "util: simplify string duplication logic" --- tests/util/piglit-shader-test.c | 2 +- 1 fi