Re: [Mesa-dev] [PATCH] util/u_atomic: Add new macro p_atomic_add

2015-02-09 Thread Carl Worth
On Mon, Feb 09 2015, Jose Fonseca wrote: > Just one more tweak to InterlockedExchangeAdd64 as per patch attached. .. > With that u_test_atomic builds and passes for me both on 32 and > 64bits. Excellent. Thanks for the fix and for the testing report. > Sorry for the delay. And thanks for your he

Re: [Mesa-dev] [PATCH] util/u_atomic: Add new macro p_atomic_add

2015-02-09 Thread Jose Fonseca
On 06/02/15 22:39, Carl Worth wrote: On Fri, Feb 06 2015, Aaron Watry wrote: Ignore me if this is a stupid question, but should those both be sizeof(short)? I'd expect the first to be sizeof(char). Not a stupid question. That was a copy-and-paste (kill-and-yank ?) bug of mine. Thanks for you

Re: [Mesa-dev] [PATCH] util/u_atomic: Add new macro p_atomic_add

2015-02-06 Thread Carl Worth
On Fri, Feb 06 2015, Aaron Watry wrote: > Ignore me if this is a stupid question, but should those both be > sizeof(short)? I'd expect the first to be sizeof(char). Not a stupid question. That was a copy-and-paste (kill-and-yank ?) bug of mine. Thanks for your attention to detail. I've fixed thi

Re: [Mesa-dev] [PATCH] util/u_atomic: Add new macro p_atomic_add

2015-02-06 Thread Aaron Watry
On Fri, Feb 6, 2015 at 1:43 PM, Carl Worth wrote: > This provides for atomic addition, which will be used by an upcoming > shader-cache patch. A simple test is added to "make check" as well. > > Note: The various O/S functions differ on whether they return the > original value or the value after

Re: [Mesa-dev] [PATCH] util/u_atomic: Add new macro p_atomic_add

2015-02-06 Thread Matt Turner
On Fri, Feb 6, 2015 at 11:43 AM, Carl Worth wrote: > This provides for atomic addition, which will be used by an upcoming > shader-cache patch. A simple test is added to "make check" as well. > > Note: The various O/S functions differ on whether they return the > original value or the value after

[Mesa-dev] [PATCH] util/u_atomic: Add new macro p_atomic_add

2015-02-06 Thread Carl Worth
This provides for atomic addition, which will be used by an upcoming shader-cache patch. A simple test is added to "make check" as well. Note: The various O/S functions differ on whether they return the original value or the value after the addition, so I did not provide an add_return() macro whic