Re: [Mesa-dev] [PATCH] util/hash_table: Rework the API to know about hashing

2014-11-26 Thread Eric Anholt
Timothy Arceri writes: > On the subject of the hash table performance I spent way to much time > looking into this recently. In the end it was taking up to much time > benchmarking and profiling for what it was worth (at least in my test > cases) so I've moved on for now. However for those interes

Re: [Mesa-dev] [PATCH] util/hash_table: Rework the API to know about hashing

2014-11-25 Thread Timothy Arceri
On Tue, 2014-11-25 at 01:56 -0500, Connor Abbott wrote: > On Tue, Nov 25, 2014 at 1:19 AM, Jason Ekstrand wrote: > > Previously, the hash_table API required the user to do all of the hashing > > of keys as it passed them in. Since the hashing function is intrinsicly > > tied to the comparison fun

Re: [Mesa-dev] [PATCH] util/hash_table: Rework the API to know about hashing

2014-11-25 Thread Jason Ekstrand
On Tue, Nov 25, 2014 at 3:40 PM, Eric Anholt wrote: > Jason Ekstrand writes: > > > Previously, the hash_table API required the user to do all of the hashing > > of keys as it passed them in. Since the hashing function is intrinsicly > > tied to the comparison function, it makes sense for the ha

Re: [Mesa-dev] [PATCH] util/hash_table: Rework the API to know about hashing

2014-11-25 Thread Eric Anholt
Jason Ekstrand writes: > Previously, the hash_table API required the user to do all of the hashing > of keys as it passed them in. Since the hashing function is intrinsicly > tied to the comparison function, it makes sense for the hash table to know > about it. Also, it makes for a somewhat clu

Re: [Mesa-dev] [PATCH] util/hash_table: Rework the API to know about hashing

2014-11-25 Thread Kenneth Graunke
On Monday, November 24, 2014 10:19:50 PM Jason Ekstrand wrote: > Previously, the hash_table API required the user to do all of the hashing > of keys as it passed them in. Since the hashing function is intrinsicly > tied to the comparison function, it makes sense for the hash table to know > about

Re: [Mesa-dev] [PATCH] util/hash_table: Rework the API to know about hashing

2014-11-24 Thread Connor Abbott
On Tue, Nov 25, 2014 at 1:19 AM, Jason Ekstrand wrote: > Previously, the hash_table API required the user to do all of the hashing > of keys as it passed them in. Since the hashing function is intrinsicly > tied to the comparison function, it makes sense for the hash table to know > about it. Al

Re: [Mesa-dev] [PATCH] util/hash_table: Rework the API to know about hashing

2014-11-24 Thread Jason Ekstrand
If people like this change, I'll do the same thing to the hash set implementation. --Jason On Mon, Nov 24, 2014 at 10:19 PM, Jason Ekstrand wrote: > Previously, the hash_table API required the user to do all of the hashing > of keys as it passed them in. Since the hashing function is intrinsicl

[Mesa-dev] [PATCH] util/hash_table: Rework the API to know about hashing

2014-11-24 Thread Jason Ekstrand
Previously, the hash_table API required the user to do all of the hashing of keys as it passed them in. Since the hashing function is intrinsicly tied to the comparison function, it makes sense for the hash table to know about it. Also, it makes for a somewhat clumsy API as the user is constantly