Re: [Mesa-dev] [PATCH] swrast: fix possible null dereference

2016-03-09 Thread Lars Hamre
Sounds good, is there a protocol to signify a patch isn't active anymore? On 03/09/2016 04:37 PM, Lars Hamre wrote: > I have not been able to force a NULL dereference, this is based off > analyzing the code. > Yes that is implicitly true, but if at some point the implicit > relationship is broken,

Re: [Mesa-dev] [PATCH] swrast: fix possible null dereference

2016-03-09 Thread Brian Paul
On 03/09/2016 04:37 PM, Lars Hamre wrote: I have not been able to force a NULL dereference, this is based off analyzing the code. Yes that is implicitly true, but if at some point the implicit relationship is broken, I would rather not have a NULL dereference. If you do not agree, I am fine defe

Re: [Mesa-dev] [PATCH] swrast: fix possible null dereference

2016-03-09 Thread Lars Hamre
I have not been able to force a NULL dereference, this is based off analyzing the code. Yes that is implicitly true, but if at some point the implicit relationship is broken, I would rather not have a NULL dereference. If you do not agree, I am fine deferring to your judgement! On Wed, Mar 9, 201

Re: [Mesa-dev] [PATCH] swrast: fix possible null dereference

2016-03-09 Thread Ian Romanick
On 03/09/2016 10:21 AM, Lars Hamre wrote: > Fixes a possible null dereference. > > NOTE: this is my first time contributing, please let me know if I > should be doing anything differently, thanks! > > Signed-off-by: Lars Hamre > --- > src/mesa/swrast/s_triangle.c | 7 --- > 1 file cha

Re: [Mesa-dev] [PATCH] swrast: fix possible null dereference

2016-03-09 Thread Anuj Phogat
On Wed, Mar 9, 2016 at 10:21 AM, Lars Hamre wrote: > Fixes a possible null dereference. > > NOTE: this is my first time contributing, please let me know if I > should be doing anything differently, thanks! Welcome to mesa-dev Lars. > > Signed-off-by: Lars Hamre > --- > src/mesa/swrast/s_t

[Mesa-dev] [PATCH] swrast: fix possible null dereference

2016-03-09 Thread Lars Hamre
Fixes a possible null dereference. NOTE: this is my first time contributing, please let me know if I should be doing anything differently, thanks! Signed-off-by: Lars Hamre --- src/mesa/swrast/s_triangle.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/mesa