Re: [Mesa-dev] [PATCH] svga: fix format_conversion_table breakage

2017-10-16 Thread Eric Engestrom
On Monday, 2017-10-16 14:28:57 +, Brian Paul wrote: > On 10/16/2017 04:24 AM, Eric Engestrom wrote: > > On Saturday, 2017-10-14 16:52:29 +, Brian Paul wrote: > > > The new A1B5G5R5_UNORM, X1B5G5R5_UNORM formats were added in the > > > wrong place > > > > Can you explain why this was wrong,

Re: [Mesa-dev] [PATCH] svga: fix format_conversion_table breakage

2017-10-16 Thread Emil Velikov
On 16 October 2017 at 15:29, Brian Paul wrote: > On 10/16/2017 08:07 AM, Emil Velikov wrote: >> >> On 16 October 2017 at 11:24, Eric Engestrom >> wrote: >>> >>> On Saturday, 2017-10-14 16:52:29 +, Brian Paul wrote: The new A1B5G5R5_UNORM, X1B5G5R5_UNORM formats were added in the >>>

Re: [Mesa-dev] [PATCH] svga: fix format_conversion_table breakage

2017-10-16 Thread Brian Paul
On 10/16/2017 08:07 AM, Emil Velikov wrote: On 16 October 2017 at 11:24, Eric Engestrom wrote: On Saturday, 2017-10-14 16:52:29 +, Brian Paul wrote: The new A1B5G5R5_UNORM, X1B5G5R5_UNORM formats were added in the wrong place Can you explain why this was wrong, so that one doesn't make t

Re: [Mesa-dev] [PATCH] svga: fix format_conversion_table breakage

2017-10-16 Thread Brian Paul
On 10/16/2017 04:24 AM, Eric Engestrom wrote: On Saturday, 2017-10-14 16:52:29 +, Brian Paul wrote: The new A1B5G5R5_UNORM, X1B5G5R5_UNORM formats were added in the wrong place Can you explain why this was wrong, so that one doesn't make the same mistake next time? Maybe add that as a comm

Re: [Mesa-dev] [PATCH] svga: fix format_conversion_table breakage

2017-10-16 Thread Emil Velikov
On 16 October 2017 at 11:24, Eric Engestrom wrote: > On Saturday, 2017-10-14 16:52:29 +, Brian Paul wrote: >> The new A1B5G5R5_UNORM, X1B5G5R5_UNORM formats were added in the >> wrong place > > Can you explain why this was wrong, so that one doesn't make the same > mistake next time? Maybe add

Re: [Mesa-dev] [PATCH] svga: fix format_conversion_table breakage

2017-10-16 Thread Eric Engestrom
On Saturday, 2017-10-14 16:52:29 +, Brian Paul wrote: > The new A1B5G5R5_UNORM, X1B5G5R5_UNORM formats were added in the > wrong place Can you explain why this was wrong, so that one doesn't make the same mistake next time? Maybe add that as a comment atop the array? (Is it a simple case of "a

[Mesa-dev] [PATCH] svga: fix format_conversion_table breakage

2017-10-14 Thread Brian Paul
The new A1B5G5R5_UNORM, X1B5G5R5_UNORM formats were added in the wrong place in commit ef874ee450b18e "gallium: Add support for 5551 with the 1-bit field in the low bit." --- src/gallium/drivers/svga/svga_format.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/