Re: [Mesa-dev] [PATCH] st: Add cubeMapFace parameter to st_finalize_texture.

2017-04-01 Thread Nicolai Hähnle
Pushed. On 29.03.2017 21:58, Marek Olšák wrote: I'm OK with this patch. Marek On Wed, Mar 29, 2017 at 12:57 PM, Nicolai Hähnle wrote: Hi Michal, thanks for the patch. That piglit test actually fails on radeonsi as well. On 28.03.2017 22:39, Michal Srb wrote: st_finalize_texture always a

Re: [Mesa-dev] [PATCH] st: Add cubeMapFace parameter to st_finalize_texture.

2017-03-29 Thread Marek Olšák
I'm OK with this patch. Marek On Wed, Mar 29, 2017 at 12:57 PM, Nicolai Hähnle wrote: > Hi Michal, > > thanks for the patch. That piglit test actually fails on radeonsi as well. > > > On 28.03.2017 22:39, Michal Srb wrote: >> >> st_finalize_texture always accesses image at face 0, but it may not

Re: [Mesa-dev] [PATCH] st: Add cubeMapFace parameter to st_finalize_texture.

2017-03-29 Thread Nicolai Hähnle
Hi Michal, thanks for the patch. That piglit test actually fails on radeonsi as well. On 28.03.2017 22:39, Michal Srb wrote: st_finalize_texture always accesses image at face 0, but it may not be set if we are working with cubemap that had other face set. This fixes crash in piglit same-att

[Mesa-dev] [PATCH] st: Add cubeMapFace parameter to st_finalize_texture.

2017-03-28 Thread Michal Srb
st_finalize_texture always accesses image at face 0, but it may not be set if we are working with cubemap that had other face set. This fixes crash in piglit same-attachment-glFramebufferTexture2D-GL_DEPTH_STENCIL_ATTACHMENT. --- Hi, this is my attempt to fix crash in piglit test same-attachmen