Re: [Mesa-dev] [PATCH] st/mesa: use pipe_sampler_view_release for releasing sampler views

2014-10-03 Thread Christian König
Am 02.10.2014 um 22:37 schrieb Alex Deucher: On Thu, Oct 2, 2014 at 1:51 PM, Christian König wrote: Am 02.10.2014 um 19:34 schrieb Marek Olšák: From: Marek Olšák This fixes a crash when exiting Firefox. I have really no idea how Firefox does it. It seems to involve multiple contexts and mult

Re: [Mesa-dev] [PATCH] st/mesa: use pipe_sampler_view_release for releasing sampler views

2014-10-02 Thread Alex Deucher
On Thu, Oct 2, 2014 at 1:51 PM, Christian König wrote: > Am 02.10.2014 um 19:34 schrieb Marek Olšák: >> >> From: Marek Olšák >> >> This fixes a crash when exiting Firefox. I have really no idea how Firefox >> does it. It seems to involve multiple contexts and multithreading. > > > That looks to m

Re: [Mesa-dev] [PATCH] st/mesa: use pipe_sampler_view_release for releasing sampler views

2014-10-02 Thread Christian König
Am 02.10.2014 um 19:34 schrieb Marek Olšák: From: Marek Olšák This fixes a crash when exiting Firefox. I have really no idea how Firefox does it. It seems to involve multiple contexts and multithreading. That looks to me like we now release all sampler views with the current context and not

[Mesa-dev] [PATCH] st/mesa: use pipe_sampler_view_release for releasing sampler views

2014-10-02 Thread Marek Olšák
From: Marek Olšák This fixes a crash when exiting Firefox. I have really no idea how Firefox does it. It seems to involve multiple contexts and multithreading. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=81680 Cc: 10.2 10.3 Tested-by: Benjamin Bellec --- src/mesa/state_tracker/st_

Re: [Mesa-dev] [PATCH] st/mesa: use pipe_sampler_view_release()

2013-12-22 Thread Jonathan Liu
On 15/12/2013 4:14 AM, Brian Paul wrote: On 12/14/2013 07:15 AM, Jonathan Liu wrote: This fixes a crash where old_view->context was already freed in the pipe_sampler_view_reference function contained in src/gallium/auxiliary/utils/u_inlines.h. As a result, the sampler_view_destroy function point

Re: [Mesa-dev] [PATCH] st/mesa: use pipe_sampler_view_release()

2013-12-14 Thread Brian Paul
On 12/14/2013 07:15 AM, Jonathan Liu wrote: This fixes a crash where old_view->context was already freed in the pipe_sampler_view_reference function contained in src/gallium/auxiliary/utils/u_inlines.h. As a result, the sampler_view_destroy function pointer contained 0xfeeefeee indicating freed h

[Mesa-dev] [PATCH] st/mesa: use pipe_sampler_view_release()

2013-12-14 Thread Jonathan Liu
This fixes a crash where old_view->context was already freed in the pipe_sampler_view_reference function contained in src/gallium/auxiliary/utils/u_inlines.h. As a result, the sampler_view_destroy function pointer contained 0xfeeefeee indicating freed heap memory. Signed-off-by: Jonathan Liu ---

Re: [Mesa-dev] [PATCH] st/mesa: use pipe_sampler_view_release() in st_destroy_context_priv()

2012-05-19 Thread Jose Fonseca
Sounds good. Jose - Original Message - > Fixes another case of sampler views being created by one context, > shared by another, then deleted by the first, leaving a dangling > pipe context pointer. > --- > src/mesa/state_tracker/st_context.c |2 +- > 1 files changed, 1 insertions(+),

[Mesa-dev] [PATCH] st/mesa: use pipe_sampler_view_release() in st_destroy_context_priv()

2012-05-18 Thread Brian Paul
Fixes another case of sampler views being created by one context, shared by another, then deleted by the first, leaving a dangling pipe context pointer. --- src/mesa/state_tracker/st_context.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/mesa/state_tracker/st_conte