Re: [Mesa-dev] [PATCH] st/mesa: remove copy-propagation pass

2015-03-25 Thread Ilia Mirkin
On Wed, Mar 25, 2015 at 4:44 PM, Tom Stellard wrote: > On Wed, Mar 25, 2015 at 04:35:03PM -0400, Ilia Mirkin wrote: >> On Wed, Mar 25, 2015 at 4:27 PM, Dave Airlie wrote: >> > On 26 March 2015 at 06:07, Ilia Mirkin wrote: >> >> So what do you do when someone goes to shadertoy.com which on >>

Re: [Mesa-dev] [PATCH] st/mesa: remove copy-propagation pass

2015-03-25 Thread Tom Stellard
On Wed, Mar 25, 2015 at 04:35:03PM -0400, Ilia Mirkin wrote: > On Wed, Mar 25, 2015 at 4:27 PM, Dave Airlie wrote: > > On 26 March 2015 at 06:07, Ilia Mirkin wrote: > >> So what do you do when someone goes to shadertoy.com which on > >> average uses 1000 temps? > > > > Fall over in a heap, li

Re: [Mesa-dev] [PATCH] st/mesa: remove copy-propagation pass

2015-03-25 Thread Ilia Mirkin
On Wed, Mar 25, 2015 at 4:27 PM, Dave Airlie wrote: > On 26 March 2015 at 06:07, Ilia Mirkin wrote: >> So what do you do when someone goes to shadertoy.com which on >> average uses 1000 temps? > > Fall over in a heap, like every other driver on shadertoy, nouveau (nv50/nvc0) tends to do pret

Re: [Mesa-dev] [PATCH] st/mesa: remove copy-propagation pass

2015-03-25 Thread Dave Airlie
On 26 March 2015 at 06:07, Ilia Mirkin wrote: > So what do you do when someone goes to shadertoy.com which on > average uses 1000 temps? Fall over in a heap, like every other driver on shadertoy, This would be raelly bad for r600g in its present state, since it doesn't go TGSI->SB yet, and t

Re: [Mesa-dev] [PATCH] st/mesa: remove copy-propagation pass

2015-03-25 Thread Ilia Mirkin
So what do you do when someone goes to shadertoy.com which on average uses 1000 temps? On Wed, Mar 25, 2015 at 3:21 PM, Brian Paul wrote: > The problem is, our binary shader interface only supports 32 temps at this > time. We sometimes bump into that limit as-is. > > -Brian > > > On 03/25/20

Re: [Mesa-dev] [PATCH] st/mesa: remove copy-propagation pass

2015-03-25 Thread Brian Paul
The problem is, our binary shader interface only supports 32 temps at this time. We sometimes bump into that limit as-is. -Brian On 03/25/2015 01:04 PM, Ilia Mirkin wrote: Yes, more temp registers and more instructions. But presumably the backend has an optimization pass that is at least as g

Re: [Mesa-dev] [PATCH] st/mesa: remove copy-propagation pass

2015-03-25 Thread Ilia Mirkin
Yes, more temp registers and more instructions. But presumably the backend has an optimization pass that is at least as good as this one (hopefully better!). Is that not the case for vmware? On Wed, Mar 25, 2015 at 2:59 PM, Brian Paul wrote: > Will removing this pass have much effect on the numbe

Re: [Mesa-dev] [PATCH] st/mesa: remove copy-propagation pass

2015-03-25 Thread Brian Paul
Will removing this pass have much effect on the number of temp regs used? It looks like more instructions may be emitted w/out this pass. We're kind of sensitive to that in the VMware driver. -Brian On 03/25/2015 12:16 PM, Marek Olšák wrote: Reviewed-by: Marek Olšák I might need to wait fo

Re: [Mesa-dev] [PATCH] st/mesa: remove copy-propagation pass

2015-03-25 Thread Rob Clark
On Wed, Mar 25, 2015 at 2:16 PM, Marek Olšák wrote: > Reviewed-by: Marek Olšák > > I might need to wait for other people's opinion too. I guess technically a2xx backend might suffer.. not even really sure about that, but meh. We can probably eventually do tgsi->nir->optimize->tgsi if it was tha

Re: [Mesa-dev] [PATCH] st/mesa: remove copy-propagation pass

2015-03-25 Thread Marek Olšák
Reviewed-by: Marek Olšák I might need to wait for other people's opinion too. Marek On Wed, Mar 25, 2015 at 6:34 PM, Ilia Mirkin wrote: > It's buggy and unnecessary in the presence of optimizing backends. The > only backend that will suffer is nv30, but... meh. > > Bugzilla: https://bugs.freed

[Mesa-dev] [PATCH] st/mesa: remove copy-propagation pass

2015-03-25 Thread Ilia Mirkin
It's buggy and unnecessary in the presence of optimizing backends. The only backend that will suffer is nv30, but... meh. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=89759 Signed-off-by: Ilia Mirkin --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 199 - 1