Re: [Mesa-dev] [PATCH] st/mesa: release EGLImage on EGLImageTarget* error

2017-07-04 Thread Lucas Stach
Am Montag, den 03.07.2017, 17:18 +0200 schrieb Marek Olšák: > Reviewed-by: Marek Olšák Thanks, pushed. > On Fri, Jun 30, 2017 at 11:03 AM, Philipp Zabel > wrote: > > The smapi->get_egl_image() call in st_egl_image_get_surface() stores a > > reference to the EGLImage's texture in stimg.texture.

Re: [Mesa-dev] [PATCH] st/mesa: release EGLImage on EGLImageTarget* error

2017-07-03 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Fri, Jun 30, 2017 at 11:03 AM, Philipp Zabel wrote: > The smapi->get_egl_image() call in st_egl_image_get_surface() stores a > reference to the EGLImage's texture in stimg.texture. That reference is > released via pipe_resource_reference(&stimg.texture, NULL) b

[Mesa-dev] [PATCH] st/mesa: release EGLImage on EGLImageTarget* error

2017-06-30 Thread Philipp Zabel
The smapi->get_egl_image() call in st_egl_image_get_surface() stores a reference to the EGLImage's texture in stimg.texture. That reference is released via pipe_resource_reference(&stimg.texture, NULL) before stimg goes out of scope at the end of the function, but not in the error path if !is_forma