Re: [Mesa-dev] [PATCH] st/mesa: fix sampler_view REALLOC/FREE macro mix-up

2014-04-10 Thread Jakob Bornecrantz
On 10 Apr 2014 15:56, "Brian Paul" wrote: > > On 04/10/2014 01:43 AM, Jakob Bornecrantz wrote: >> >> On Thu, Apr 10, 2014 at 3:26 AM, Brian Paul wrote: >>> >>> We were using REALLOC() from u_memory.h but FREE() from imports.h. >>> This mismatch caused us to trash the heap on Windows after we >>>

Re: [Mesa-dev] [PATCH] st/mesa: fix sampler_view REALLOC/FREE macro mix-up

2014-04-10 Thread Brian Paul
On 04/10/2014 01:43 AM, Jakob Bornecrantz wrote: On Thu, Apr 10, 2014 at 3:26 AM, Brian Paul wrote: We were using REALLOC() from u_memory.h but FREE() from imports.h. This mismatch caused us to trash the heap on Windows after we deleted a texture object. This fixes a regression from commit 6c5

Re: [Mesa-dev] [PATCH] st/mesa: fix sampler_view REALLOC/FREE macro mix-up

2014-04-10 Thread Jose Fonseca
To prevent this to ocurr again in the future we should be probably using os_malloc/os_free and friends instead of the overloaded MALLOC/FREE/etc macros. We should probably kill MALLOC/FREE completely. Jose - Original Message - > We were using REALLOC() from u_memory.h but FREE() from im

Re: [Mesa-dev] [PATCH] st/mesa: fix sampler_view REALLOC/FREE macro mix-up

2014-04-10 Thread Christian König
Am 10.04.2014 03:26, schrieb Brian Paul: We were using REALLOC() from u_memory.h but FREE() from imports.h. This mismatch caused us to trash the heap on Windows after we deleted a texture object. This fixes a regression from commit 6c59be7776e4d. Reviewed-by: Christian König --- src/mesa/

Re: [Mesa-dev] [PATCH] st/mesa: fix sampler_view REALLOC/FREE macro mix-up

2014-04-10 Thread Jakob Bornecrantz
On Thu, Apr 10, 2014 at 3:26 AM, Brian Paul wrote: > We were using REALLOC() from u_memory.h but FREE() from imports.h. > This mismatch caused us to trash the heap on Windows after we > deleted a texture object. > > This fixes a regression from commit 6c59be7776e4d. > --- > src/mesa/state_tracker

[Mesa-dev] [PATCH] st/mesa: fix sampler_view REALLOC/FREE macro mix-up

2014-04-09 Thread Brian Paul
We were using REALLOC() from u_memory.h but FREE() from imports.h. This mismatch caused us to trash the heap on Windows after we deleted a texture object. This fixes a regression from commit 6c59be7776e4d. --- src/mesa/state_tracker/st_cb_texture.c |2 +- src/mesa/state_tracker/st_texture.c