Re: [Mesa-dev] [PATCH] st/mesa: allow glDrawElements to work with GL_SELECT feedback

2018-12-26 Thread Ilia Mirkin
On Wed, Dec 19, 2018 at 10:12 AM Brian Paul wrote: > > On 12/19/2018 06:47 AM, Ilia Mirkin wrote: > > On Wed, Dec 19, 2018 at 8:38 AM Brian Paul wrote: > >> > >> On 12/18/2018 08:50 PM, Ilia Mirkin wrote: > >>> Not sure if this ever worked, but the current logic for setting the > >>> min/max inde

Re: [Mesa-dev] [PATCH] st/mesa: allow glDrawElements to work with GL_SELECT feedback

2018-12-19 Thread Roland Scheidegger
Fix looks good to me. Reviewed-by: Roland Scheidegger Am 19.12.18 um 04:50 schrieb Ilia Mirkin: > Not sure if this ever worked, but the current logic for setting the > min/max index is definitely wrong for indexed draws. While we're at it, > bring in all the usual logic from the non-indirect dr

Re: [Mesa-dev] [PATCH] st/mesa: allow glDrawElements to work with GL_SELECT feedback

2018-12-19 Thread Brian Paul
On 12/19/2018 06:47 AM, Ilia Mirkin wrote: > On Wed, Dec 19, 2018 at 8:38 AM Brian Paul wrote: >> >> On 12/18/2018 08:50 PM, Ilia Mirkin wrote: >>> Not sure if this ever worked, but the current logic for setting the >>> min/max index is definitely wrong for indexed draws. While we're at it, >>> br

Re: [Mesa-dev] [PATCH] st/mesa: allow glDrawElements to work with GL_SELECT feedback

2018-12-19 Thread Ilia Mirkin
On Wed, Dec 19, 2018 at 8:38 AM Brian Paul wrote: > > On 12/18/2018 08:50 PM, Ilia Mirkin wrote: > > Not sure if this ever worked, but the current logic for setting the > > min/max index is definitely wrong for indexed draws. While we're at it, > > bring in all the usual logic from the non-indirec

Re: [Mesa-dev] [PATCH] st/mesa: allow glDrawElements to work with GL_SELECT feedback

2018-12-19 Thread Brian Paul
On 12/18/2018 08:50 PM, Ilia Mirkin wrote: > Not sure if this ever worked, but the current logic for setting the > min/max index is definitely wrong for indexed draws. While we're at it, > bring in all the usual logic from the non-indirect drawing path. > > Bugzilla: > https://na01.safelinks.prot

[Mesa-dev] [PATCH] st/mesa: allow glDrawElements to work with GL_SELECT feedback

2018-12-18 Thread Ilia Mirkin
Not sure if this ever worked, but the current logic for setting the min/max index is definitely wrong for indexed draws. While we're at it, bring in all the usual logic from the non-indirect drawing path. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109086 Signed-off-by: Ilia Mirkin ---