Re: [Mesa-dev] [PATCH] st/mesa: Fix an incorrect user vertex buffer reference

2011-03-08 Thread Marek Olšák
FYI I have gone ahead and pushed this, so that I can close bug 34378. Marek On Mon, Mar 7, 2011 at 11:24 AM, Thomas Hellstrom wrote: > st->user_vb[attr] was always pointing to the same user vb, regardless > of the value of attr. Together with reverting the temporary workaround > for bug 34378, a

Re: [Mesa-dev] [PATCH] st/mesa: Fix an incorrect user vertex buffer reference

2011-03-07 Thread Marek Olšák
On Mon, Mar 7, 2011 at 6:12 PM, Thomas Hellstrom wrote: > On 03/07/2011 05:55 PM, Marek Olšák wrote: > > Thank you very much for looking into this. It looks good to me, but it > still doesn't fix bug 34378 (tested with sauerbraten), so the second hunk > shouldn't be committed yet. > > > Ouch. The

Re: [Mesa-dev] [PATCH] st/mesa: Fix an incorrect user vertex buffer reference

2011-03-07 Thread Thomas Hellstrom
On 03/07/2011 05:55 PM, Marek Olšák wrote: Thank you very much for looking into this. It looks good to me, but it still doesn't fix bug 34378 (tested with sauerbraten), so the second hunk shouldn't be committed yet. Ouch. The problem is that without the second hunk, redefine_user_buffers will

Re: [Mesa-dev] [PATCH] st/mesa: Fix an incorrect user vertex buffer reference

2011-03-07 Thread Marek Olšák
Thank you very much for looking into this. It looks good to me, but it still doesn't fix bug 34378 (tested with sauerbraten), so the second hunk shouldn't be committed yet. Marek On Mon, Mar 7, 2011 at 11:24 AM, Thomas Hellstrom wrote: > st->user_vb[attr] was always pointing to the same user vb,

Re: [Mesa-dev] [PATCH] st/mesa: Fix an incorrect user vertex buffer reference

2011-03-07 Thread José Fonseca
Nice catch. Jose On Mon, 2011-03-07 at 02:24 -0800, Thomas Hellstrom wrote: > st->user_vb[attr] was always pointing to the same user vb, regardless > of the value of attr. Together with reverting the temporary workaround > for bug 34378, and a fix in the svga driver, this fixes googleearth on svg

[Mesa-dev] [PATCH] st/mesa: Fix an incorrect user vertex buffer reference

2011-03-07 Thread Thomas Hellstrom
st->user_vb[attr] was always pointing to the same user vb, regardless of the value of attr. Together with reverting the temporary workaround for bug 34378, and a fix in the svga driver, this fixes googleearth on svga. Signed-off-by: Thomas Hellstrom --- src/mesa/state_tracker/st_draw.c |6 ++