Re: [Mesa-dev] [PATCH] spirv: fix AtomicLoad/Store on images

2016-09-19 Thread Jason Ekstrand
This looks good to me. Reviewed-by: Jason Ekstrand Do we have tests for this? If not, we should write some. I know there are other image atomic tests in the CTS. They shouldn't be hard to extend. On Sep 19, 2016 9:36 AM, "Lionel Landwerlin" wrote: > OpAtomicLoad/Store should have pointer to

Re: [Mesa-dev] [PATCH] spirv: fix AtomicLoad/Store on images

2016-09-19 Thread Lionel Landwerlin
On 19/09/16 18:02, Jason Ekstrand wrote: This looks good to me. Reviewed-by: Jason Ekstrand > Do we have tests for this? If not, we should write some. I know there are other image atomic tests in the CTS. They shouldn't be hard to extend. Not that I saw. I'l

[Mesa-dev] [PATCH] spirv: fix AtomicLoad/Store on images

2016-09-19 Thread Lionel Landwerlin
OpAtomicLoad/Store should have pointer to images just like the rest of the atomic operators. These couple of lines were poorly copied from the ssbo/shared_vars cases (the only ones currently tests by the CTS). Fixes 2afb950161f847d9b0a7 "spirv/nir: Add support for OpAtomicLoad/Store" Cc: Timothy A