Re: [Mesa-dev] [PATCH] radv: fix vkCmdCopyQueryoolResults() for timestamp queries

2018-12-05 Thread Alex Smith
On Tue, 4 Dec 2018 at 21:57, Bas Nieuwenhuizen wrote: > On Tue, Dec 4, 2018 at 4:52 PM Samuel Pitoiset > wrote: > > > > Because WAIT_REG_MEM can only wait for a 32-bit value, it's not > > safe to use it for timestamp queries. If we only wait on the low > > 32 bits of a timestamp query we could b

Re: [Mesa-dev] [PATCH] radv: fix vkCmdCopyQueryoolResults() for timestamp queries

2018-12-04 Thread Bas Nieuwenhuizen
On Tue, Dec 4, 2018 at 4:52 PM Samuel Pitoiset wrote: > > Because WAIT_REG_MEM can only wait for a 32-bit value, it's not > safe to use it for timestamp queries. If we only wait on the low > 32 bits of a timestamp query we could be unlucky and the GPU > might hang. > > One possible fix is to emit

Re: [Mesa-dev] [PATCH] radv: fix vkCmdCopyQueryoolResults() for timestamp queries

2018-12-04 Thread Alex Smith
Tested-by: Alex Smith Thanks! s/Queryool/QueryPool/ in the subject, btw. On Tue, 4 Dec 2018 at 15:52, Samuel Pitoiset wrote: > Because WAIT_REG_MEM can only wait for a 32-bit value, it's not > safe to use it for timestamp queries. If we only wait on the low > 32 bits of a timestamp query we co

[Mesa-dev] [PATCH] radv: fix vkCmdCopyQueryoolResults() for timestamp queries

2018-12-04 Thread Samuel Pitoiset
Because WAIT_REG_MEM can only wait for a 32-bit value, it's not safe to use it for timestamp queries. If we only wait on the low 32 bits of a timestamp query we could be unlucky and the GPU might hang. One possible fix is to emit a full end of pipe event and wait on a 32-bit value which is actuall