Re: [Mesa-dev] [PATCH] radv: fix sample_mask_in loading. (v3)

2018-01-25 Thread Emil Velikov
On 23 January 2018 at 23:00, Dave Airlie wrote: > From: Dave Airlie > > This is ported from radeonsi and fixes: > dEQP-VK.pipeline.multisample_shader_builtin.sample_mask.bit_* > > v2: don't call this path for radeonsi, it does it in the epilog. > use the radeonsi code path. > v3: handle NULL pCre

Re: [Mesa-dev] [PATCH] radv: fix sample_mask_in loading. (v3)

2018-01-23 Thread Bas Nieuwenhuizen
On Wed, Jan 24, 2018 at 12:00 AM, Dave Airlie wrote: > From: Dave Airlie > > This is ported from radeonsi and fixes: > dEQP-VK.pipeline.multisample_shader_builtin.sample_mask.bit_* > > v2: don't call this path for radeonsi, it does it in the epilog. > use the radeonsi code path. > v3: handle NULL

[Mesa-dev] [PATCH] radv: fix sample_mask_in loading. (v3)

2018-01-23 Thread Dave Airlie
From: Dave Airlie This is ported from radeonsi and fixes: dEQP-VK.pipeline.multisample_shader_builtin.sample_mask.bit_* v2: don't call this path for radeonsi, it does it in the epilog. use the radeonsi code path. v3: handle NULL pCreateInfo->pMultisampleState properly (Samuel) Signed-off-by: Da

Re: [Mesa-dev] [PATCH] radv: fix sample_mask_in loading. (v2)

2018-01-23 Thread Samuel Pitoiset
On 01/23/2018 04:00 AM, Dave Airlie wrote: From: Dave Airlie This is ported from radeonsi and fixes: dEQP-VK.pipeline.multisample_shader_builtin.sample_mask.bit_* v2: don't call this path for radeonsi, it does it in the epilog. use the radeonsi code path. Signed-off-by: Dave Airlie --- s

[Mesa-dev] [PATCH] radv: fix sample_mask_in loading. (v2)

2018-01-22 Thread Dave Airlie
From: Dave Airlie This is ported from radeonsi and fixes: dEQP-VK.pipeline.multisample_shader_builtin.sample_mask.bit_* v2: don't call this path for radeonsi, it does it in the epilog. use the radeonsi code path. Signed-off-by: Dave Airlie --- src/amd/common/ac_nir_to_llvm.c | 29

Re: [Mesa-dev] [PATCH] radv: fix sample_mask_in loading.

2018-01-22 Thread Timothy Arceri
This breaks some piglit tests on radeonsi e.g. R600_DEBUG=nir ./bin/arb_sample_shading-samplemask 2 all all -auto -fbo On 23/01/18 12:08, Dave Airlie wrote: From: Dave Airlie This is ported from amdvlk, and fixes: dEQP-VK.pipeline.multisample_shader_builtin.sample_mask.bit_* Signed-off-by: D

[Mesa-dev] [PATCH] radv: fix sample_mask_in loading.

2018-01-22 Thread Dave Airlie
From: Dave Airlie This is ported from amdvlk, and fixes: dEQP-VK.pipeline.multisample_shader_builtin.sample_mask.bit_* Signed-off-by: Dave Airlie --- src/amd/common/ac_nir_to_llvm.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/src/amd/common/ac_nir_to_llvm.c