Re: [Mesa-dev] [PATCH] radv: fix adjusting vertex fetches since 16bit support

2018-07-25 Thread Bas Nieuwenhuizen
On Wed, Jul 25, 2018 at 3:28 PM, Samuel Pitoiset wrote: > > > On 07/25/2018 03:26 PM, Bas Nieuwenhuizen wrote: >> >> On Wed, Jul 25, 2018 at 3:25 PM, Samuel Pitoiset >> wrote: >>> >>> >>> >>> On 07/25/2018 02:55 PM, Bas Nieuwenhuizen wrote: hmm, not sure why that did not fail on my

Re: [Mesa-dev] [PATCH] radv: fix adjusting vertex fetches since 16bit support

2018-07-25 Thread Samuel Pitoiset
On 07/25/2018 03:26 PM, Bas Nieuwenhuizen wrote: On Wed, Jul 25, 2018 at 3:25 PM, Samuel Pitoiset wrote: On 07/25/2018 02:55 PM, Bas Nieuwenhuizen wrote: hmm, not sure why that did not fail on my CTS runs ... Because 16bit is only enabled on Polaris? Wait what, it should be enabled on

Re: [Mesa-dev] [PATCH] radv: fix adjusting vertex fetches since 16bit support

2018-07-25 Thread Bas Nieuwenhuizen
On Wed, Jul 25, 2018 at 3:25 PM, Samuel Pitoiset wrote: > > > On 07/25/2018 02:55 PM, Bas Nieuwenhuizen wrote: >> >> hmm, not sure why that did not fail on my CTS runs ... > > > Because 16bit is only enabled on Polaris? Wait what, it should be enabled on Vega too right? > > >> >> Reviewed-by: Bas

Re: [Mesa-dev] [PATCH] radv: fix adjusting vertex fetches since 16bit support

2018-07-25 Thread Samuel Pitoiset
On 07/25/2018 02:55 PM, Bas Nieuwenhuizen wrote: hmm, not sure why that did not fail on my CTS runs ... Because 16bit is only enabled on Polaris? Reviewed-by: Bas Nieuwenhuizen On Wed, Jul 25, 2018 at 2:55 PM, Samuel Pitoiset wrote: Move the integer conversion after the fixup. This fi

Re: [Mesa-dev] [PATCH] radv: fix adjusting vertex fetches since 16bit support

2018-07-25 Thread Bas Nieuwenhuizen
hmm, not sure why that did not fail on my CTS runs ... Reviewed-by: Bas Nieuwenhuizen On Wed, Jul 25, 2018 at 2:55 PM, Samuel Pitoiset wrote: > Move the integer conversion after the fixup. > > This fixes some regressions with > dEQP-VK.pipeline.vertex_input.single_attribute.mat4.as_a2r10g10b10*

[Mesa-dev] [PATCH] radv: fix adjusting vertex fetches since 16bit support

2018-07-25 Thread Samuel Pitoiset
Move the integer conversion after the fixup. This fixes some regressions with dEQP-VK.pipeline.vertex_input.single_attribute.mat4.as_a2r10g10b10* Fixes: b722b29f10 ("radv: add support for 16bit input/output") Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_nir_to_llvm.c | 7 --- 1 fi