Re: [Mesa-dev] [PATCH] radv: do not segfault when the SPIRV entry point is NULL

2018-09-17 Thread Samuel Pitoiset
On 9/17/18 11:22 AM, Jason Ekstrand wrote: It's not the job of the driver to check these things.  Developers should be running with validation layers enabled which are supposed to catch this.  There are so many other ways things can go wrong if the user provides bad input and this only fixes

Re: [Mesa-dev] [PATCH] radv: do not segfault when the SPIRV entry point is NULL

2018-09-17 Thread Timothy Arceri
Reviewed-by: Timothy Arceri On 17/9/18 7:18 pm, Samuel Pitoiset wrote: And return a better error value. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107954 Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_pipeline.c | 32 +--- src/amd/vulkan/radv

Re: [Mesa-dev] [PATCH] radv: do not segfault when the SPIRV entry point is NULL

2018-09-17 Thread Jason Ekstrand
It's not the job of the driver to check these things. Developers should be running with validation layers enabled which are supposed to catch this. There are so many other ways things can go wrong if the user provides bad input and this only fixes one tiny one. On Mon, Sep 17, 2018 at 4:18 AM Sam

[Mesa-dev] [PATCH] radv: do not segfault when the SPIRV entry point is NULL

2018-09-17 Thread Samuel Pitoiset
And return a better error value. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107954 Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_pipeline.c | 32 +--- src/amd/vulkan/radv_shader.c | 3 +++ 2 files changed, 28 insertions(+), 7 deletions(-) diff