Re: [Mesa-dev] [PATCH] radv: allow launching waves out-of-order for compute

2017-10-09 Thread Nicolai Hähnle
At least for async compute, this is gated by HQD_PQ_CONTROL.UNORD_DISPATCH, which the kernel doesn't set. Presumably because it can increase scheduling latency between queues. I don't know if it applies to compute shaders launched via the graphics queue. In any case, turning the bit on from the

Re: [Mesa-dev] [PATCH] radv: allow launching waves out-of-order for compute

2017-10-09 Thread Dave Airlie
Do we know if Linux kernel driver enables this? Dave. On 9 Oct. 2017 6:04 pm, "Samuel Pitoiset" wrote: > > > On 10/07/2017 10:59 AM, Nicolai Hähnle wrote: > >> On 06.10.2017 16:03, Samuel Pitoiset wrote: >> >>> Ported from RadeonSI, and -pro seems to enable it as well. >>> >>> Signed-off-by: Sa

Re: [Mesa-dev] [PATCH] radv: allow launching waves out-of-order for compute

2017-10-09 Thread Samuel Pitoiset
On 10/07/2017 10:59 AM, Nicolai Hähnle wrote: On 06.10.2017 16:03, Samuel Pitoiset wrote: Ported from RadeonSI, and -pro seems to enable it as well. Signed-off-by: Samuel Pitoiset ---   src/amd/vulkan/radv_cmd_buffer.c | 11 ++-   1 file changed, 10 insertions(+), 1 deletion(-) diff

Re: [Mesa-dev] [PATCH] radv: allow launching waves out-of-order for compute

2017-10-07 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen if you remove the (same as Vulkan) bit. On Fri, Oct 6, 2017 at 4:03 PM, Samuel Pitoiset wrote: > Ported from RadeonSI, and -pro seems to enable it as well. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_cmd_buffer.c | 11 ++- > 1 file cha

Re: [Mesa-dev] [PATCH] radv: allow launching waves out-of-order for compute

2017-10-07 Thread Nicolai Hähnle
On 06.10.2017 16:03, Samuel Pitoiset wrote: Ported from RadeonSI, and -pro seems to enable it as well. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/am

[Mesa-dev] [PATCH] radv: allow launching waves out-of-order for compute

2017-10-06 Thread Samuel Pitoiset
Ported from RadeonSI, and -pro seems to enable it as well. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c index d9243beae5..c64