On Thu, Jan 4, 2018 at 4:43 AM, Mao, David wrote:
> Hi Bas,
> AMD does not support ETC2 officially on the GFX9.
> It would be risky for Radv to export that feature for gfx9 family.
> Anyway, t’s just a heads up, and it is up to you to make the final call.
> FYI: AMDVLK and proprietary AMD vulkan d
Well, if RadeonSI enables ETC2 I guess it's "safe".
Reviewed-by: Samuel Pitoiset
On 01/04/2018 01:38 AM, Bas Nieuwenhuizen wrote:
Was surprised that is even supported by Vega.
---
src/amd/vulkan/radv_device.c| 4 +++-
src/amd/vulkan/radv_formats.c | 36 +++
Interestingly enough radeonsi also exposes it as far as I can see since
commit d214b95e9a113733865546f3388a38bdee69a95f
Author: Marek Olšák
Date: Sat Oct 15 14:28:01 2016 +0200
radeonsi/gfx9: enable ETC2
Reviewed-by: Nicolai Hähnle
Thanks for the warning though.
On Thu, Jan 4, 2018
I thought the reason they are included nowadays in hardware is because
they are required by gl 4.3 and of course GLES (I think they were added
in GL via ES compatibility).
Of course, for proper gles (3.2) you also need astc, but still it looks
to me like these formats are here to stay.
Roland
Am
Hi Bas,
AMD does not support ETC2 officially on the GFX9.
It would be risky for Radv to export that feature for gfx9 family.
Anyway, t’s just a heads up, and it is up to you to make the final call.
FYI: AMDVLK and proprietary AMD vulkan driver don’t’ support that.
Thanks.
Best Regards,
David
Was surprised that is even supported by Vega.
---
src/amd/vulkan/radv_device.c| 4 +++-
src/amd/vulkan/radv_formats.c | 36
src/amd/vulkan/vk_format_layout.csv | 20 ++--
3 files changed, 49 insertions(+), 11 deletions(-)
diff --