Re: [Mesa-dev] [PATCH] radeonsi: fix out-of-bounds indexing of shader images

2016-03-22 Thread Michel Dänzer
On 22.03.2016 05:41, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > Results are undefined but may not crash. Without this change, out-of-bounds > indexing can lead to VM faults and GPU hangs. > > Constant buffers, samplers, and possibly others will eventually need similar > treatment to suppor

Re: [Mesa-dev] [PATCH] radeonsi: fix out-of-bounds indexing of shader images

2016-03-22 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Mon, Mar 21, 2016 at 9:41 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > Results are undefined but may not crash. Without this change, out-of-bounds > indexing can lead to VM faults and GPU hangs. > > Constant buffers, samplers, and possibly others will

Re: [Mesa-dev] [PATCH] radeonsi: fix out-of-bounds indexing of shader images

2016-03-21 Thread eocallaghan
Reviewed-by: Edward O'Callaghan On 2016-03-22 07:41, Nicolai Hähnle wrote: From: Nicolai Hähnle Results are undefined but may not crash. Without this change, out-of-bounds indexing can lead to VM faults and GPU hangs. Constant buffers, samplers, and possibly others will eventually need si

Re: [Mesa-dev] [PATCH] radeonsi: fix out-of-bounds indexing of shader images

2016-03-21 Thread Nicolai Hähnle
On 21.03.2016 15:41, Nicolai Hähnle wrote: From: Nicolai Hähnle Results are undefined but may not crash. Without this change, out-of-bounds indexing can lead to VM faults and GPU hangs. Constant buffers, samplers, and possibly others will eventually need similar treatment to support GL_ARB_rob

[Mesa-dev] [PATCH] radeonsi: fix out-of-bounds indexing of shader images

2016-03-21 Thread Nicolai Hähnle
From: Nicolai Hähnle Results are undefined but may not crash. Without this change, out-of-bounds indexing can lead to VM faults and GPU hangs. Constant buffers, samplers, and possibly others will eventually need similar treatment to support GL_ARB_robust_buffer_access_behavior. --- src/gallium/