Re: [Mesa-dev] [PATCH] radeonsi: fix culldist_writemask in nir path

2017-10-31 Thread Marek Olšák
Yes, si_create_shader_selector contains this: sel->culldist_mask = sel->info.culldist_writemask << sel->info.num_written_clipdistance; Reviewed-by: Marek Olšák Marek On Tue, Oct 31, 2017 at 4:26 AM, Timothy Arceri wrote: > In RADV we need to offset the writemask because >

[Mesa-dev] [PATCH] radeonsi: fix culldist_writemask in nir path

2017-10-30 Thread Timothy Arceri
In RADV we need to offset the writemask because nir_lower_clip_cull_distance_arrays() combines the arrays. However we can't use this with radeonsi currently so don't offset the writemask. Fixes the following piglit tests: arb_cull_distance/clip-cull-3.shader_test arb_cull_distance/clip-cull-4.sha